Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff view shows output changes even when there is no actual change (only change is in the metadata) #141966

Closed
minsa110 opened this issue Jan 31, 2022 · 1 comment
Closed

Diff view shows output changes even when there is no actual change (only change is in the metadata) #141966

minsa110 opened this issue Jan 31, 2022 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff

Comments

@minsa110
Copy link

Environment data

  • VS Code version: 1.64.0-insider (user setup)
  • Jupyter Extension version (available under the Extensions sidebar): v2022.1.1001760686
  • Python Extension version (available under the Extensions sidebar): v2022.0.1762517795-dev
  • OS (Windows | Mac | Linux distro) and version: Windows (WSL2)
  • Python and/or Anaconda version: conda 4.11.0
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Jupyter server running: Local

Expected behaviour

  1. Open an existing notebook
  2. Run the first cell
  3. Run all cells (so that the first cell's execution count becomes "2")
  4. Open diff view
  5. Assuming that no changes were made to the notebook / data, there shouldn't be any diffs displayed

Actual behaviour

Output is exactly the same, but is marked as "changed"
image

Because the "executionCount" changed in the output metadata
image
@minsa110 minsa110 added bug Issue identified by VS Code Team member as probable bug nb-golden labels Jan 31, 2022
@rchiodo rchiodo transferred this issue from microsoft/vscode-jupyter Feb 1, 2022
@greazer
Copy link
Member

greazer commented Feb 4, 2022

Dupe of #135820.

@greazer greazer closed this as completed Feb 4, 2022
@greazer greazer added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 4, 2022
@greazer greazer mentioned this issue Feb 9, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rebornix @minsa110 @greazer and others