Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿❗Breaking Issue - RTL Support❗🚑 #142277

Closed
babakfp opened this issue Feb 5, 2022 · 24 comments
Closed

♿❗Breaking Issue - RTL Support❗🚑 #142277

babakfp opened this issue Feb 5, 2022 · 24 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@babakfp
Copy link

babakfp commented Feb 5, 2022

This text

Screenshot 2022-02-05 071006

Screenshot 2022-02-05 070926

Most look like this:

Screenshot 2022-02-05 070826

Looks correct without that English word:

Screenshot 2022-02-05 071716


Screenshot 2022-02-05 072308


1-with-numbers-min
2-min

@TylerLeonhardt
Copy link
Member

/duplicate #11770

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

@TylerLeonhardt
Come on. Such a big issue doesn't deserve to get closed. I understand that when a problem doesn't affect us, we just don't care about it. But here I'm asking you guys to help to solve this major problem. Please reopen the issue.
I'm available on Telegram https://t.me/babakfp to help you guys on this topic. Ask me your questions.

@alexdima (have a look at my explanation)
@HamzaAbdullahMoh
@chadidi
@danyeh (😑)
@Kalmuraee
@janbaltus (dude👍)
@Aminadav
@saibimajdi
@ahamidou
@mahrousfci
@eyalalonn
@elkebirmed
@kazemihabib
@atlanteh
@iddan
@kookma
@Parsoa
@athamzaabdullah (read the explanation in this comment, that's why this problem isn't a priority)
@urielha
@omidgolparvar (این مشکل هنوز حل نشده ولی تو احتمالا الان پدر شدی😂😂)
@akosyakov
@Javanmardi
@tomerm
@adir01
@amirbrans
@amer1616
@jb6
@nathangibson
@MSKhodadady (Telegram also have problems with RTL, but it's better than vsCode)
@KL13NT
@Kagetsuki
@VehpuS
@NotWearingPants
@rafidka
@lior5654 (2022 😂)
@TheEhsanSarshar (feel free to contact me on Telegram https://t.me/babakfp)
@AhmedElTabarani
@marktani
@ebraminio (۲۰۲۲ انگار نه انگار)
@michael-james
@sarmadka
@lwcvl
@drewpotter
@fireheart2008
@RaiKoHoff
@hpwamr
@zspitz
@avipars
@sixtyfive
@RexNext
@chromer030
@amiria703

@zspitz
Copy link

zspitz commented Feb 5, 2022

@babakfp Why do you feel this issue isn't covered by #11770 ?

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

But aren't you just adding it to the (not-to-do list)? Isn't it best to take time and work on it to fix it forever? It's obviously not great for you guys too to deal with the same issue again and again and again. Do JetBrains's products support RTL correctly? If it doesn't, it's a big win for vsCode. What about other editors? I'm on Telegram https://t.me/babakfp, I'll answer all of your questions, contact me anytime and I'll stay in contact as much as it takes to solve this problem.

@vscode-triage-bot

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

@babakfp Why do you feel this issue isn't covered by #11770 ?

As you can see, it's a big confusion:

Screenshot 2022-02-05 095447

Also, it's not all about the text being on the right side / starting from right to left

@zspitz
Copy link

zspitz commented Feb 5, 2022

@babakfp That confusion is cleared up in later comments.

Also, it's not all about the text being on the right side / starting from right to left

No, it's not. I would say that isn't even the main issue. There are actually a number of issues around this, e.g.:

  • RTL1 LTR RTL2 needs to reverse direction and read RTL2 LTR RTL1
  • Parentheses (and other pair characters) need to be visually reversed if they're surrounding RTL text
  • Sets of numbers should not reverse direction within RTL text

And what makes this all worse, is that VS Code has a lot of custom positioning around cursor/selection placement that has to handle all of this.

All of this is covered in various comments in that thread, and in linked issues.

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

And what makes this all worse, is that VS Code has a lot of custom positioning around cursor/selection placement that has to handle all of this.

That doesn't sound correct. Let's walk through with an example because if I read this tomorrow, I probably going to get confused😂. This is the text in Farsi/Persian:

Screenshot 2022-02-05 111217

If I understand it correctly, you are saying that if the second letter was in English, it should be placed at the cursor's first position. So it's going to be like this:

Screenshot 2022-02-05 111643

This isn't right because nothing about the input should change!. This is the correct example:
Screenshot 2022-02-05 111833

Same as how it works on the web. If I copy a mixed lang text like (سلام babakfp خوبی؟) from the vsCode and paste it somewhere on the web, it should look the same (and vice versa).


The biggest and breaking issue here is this:

This text

Screenshot 2022-02-05 071006

Most look like this:

Screenshot 2022-02-05 070826

(Not talking about the text being on the right side).

I can explain and talk about other RTL issues but I'm afraid no one is going to fix them, same as this one.


Parentheses (and other pair characters) need to be visually reversed if they're surrounding RTL text
Sets of numbers should not reverse direction within RTL text

Any visual examples?

@AhmedElTabarani
Copy link

@babakfp Why do you feel this issue isn't covered by #11770 ?

The #11770 issue It has become a basket that any problems related to RTL languages ​​are putted into it

There may be various different problems but on the same topic.

Have you recorded the closed problems that may have different aspects of the problem?

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

The #11770 issue It has become a basket that any problems related to RTL languages ​​are putted into it

Yep. that's exactly what is happening.

@AhmedElTabarani
Copy link

@kieferrm
Can after 'Iteration Plan for January 2022 #139607' end, add #11770 in February's plan and try to solve some RTL problems?

It's not only about the display, there are side problems in the terminal or in the editor, but it was closed under the idea of that it is a duplicate

@babakfp
Copy link
Author

babakfp commented Feb 5, 2022

@babakfp
Copy link
Author

babakfp commented Feb 6, 2022

😐

@nathangibson
Copy link

@babakfp Thank you for looping me in. I agree that #11770 has a confusing history. As I understand it, the issue you're describing has to do with VS Code either detecting the base line direction automatically (per Unicode BiDi algorithm) or being able to set the direction.

#11770 does have some discussion of this, but the issues #65648, #65855, and #4994 are more concise and targeted. Those are all still open. Perhaps you'd want to continue the discussion there?

I am with you that I hope these issues get put into the pipeline and resolved soon!

@nathangibson
Copy link

@zspitz I appreciate the clarity you've brought to this over at #11770!

@amiria703
Copy link

amiria703 commented Feb 13, 2022

This issue is a disaster,
We should have separate issues for each problem and track each one on its own issue rather than mixing them in just one

@babakfp
Copy link
Author

babakfp commented Feb 21, 2022

@TylerLeonhardt ?

@babakfp
Copy link
Author

babakfp commented Feb 22, 2022

Hi there @alexr00
Anyone bored to help fix this bug?
DM me in Telegram https://t.me/babakfp if you needed help

@AhmedElTabarani
Copy link

Hi there @alexr00 Anyone bored to help fix this bug? DM me in Telegram https://t.me/babakfp if you needed help

I'm sorry, you did a great job but can't you be a little more formal and talk about it professionally
I respect what you did, and you alerted us about it
But you have become completely random and always know about communicating with you on Telegram in a strange way. Why is this?

@babakfp
Copy link
Author

babakfp commented Feb 25, 2022

Hi @AhmedElTabarani
Thank you so much. Yes, I'm trying to let them know that this is a big problem with vsCode and it must get fixed as soon as possible. Unfortunately, no one cares about our problems. It's not even like a small problem for a small group of people, it's a big problem for probably millions of people.
I'm not the kind of person to talk about this kind of stuff in a professional way. As a user what I see is that they don't care about this problem and not caring about your users problems isn't professional.
Telegram is a global way of communicating with other people but I guess it may sound weird when I say it over and over again. My only intention is for this problem to get fixed, nothing more or else.
I gonna try to talk with YouTuber to make a video about this and then vsCode may decide to fix it🤷‍♂️.
Thanks🌸🌸

@lwcvl
Copy link

lwcvl commented Feb 26, 2022

@babakfp Thanks for pushing hard for this. I would like to report on it for the online magazine www.digitalorientalist.com. May I use the images you have posted here? Maybe you can contact me off GitHub - I can't immediately track you down but I think you should have no problem contacting me.

@babakfp
Copy link
Author

babakfp commented Feb 26, 2022

Hi @lwcvl
Thanks

May I use the images you have posted here?

Sure, feel free to use whatever I posted related to this topic🌼

@babakfp
Copy link
Author

babakfp commented Feb 26, 2022

Thank you, everyone🌼🌼

@ForrestKnight
@developedbyed
@jamesqquick
@clementmihailescu
@benawad
Frying Pan ??
@hswolff
@shiffman Choo choo!
@CalebCurry
Dani Krossing ??
@iamshaunjp 🥷

@babakfp
Copy link
Author

babakfp commented Mar 21, 2022

What da hell dude!
@TylerLeonhardt
Which team's responsibility this is? Don't you people get paid? It's not been fixed since 2016! HELLOOOOO?

@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

8 participants
@zspitz @TylerLeonhardt @nathangibson @babakfp @lwcvl @amiria703 @AhmedElTabarani and others