-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿❗Breaking Issue - RTL Support❗🚑 #142277
Comments
/duplicate #11770 |
@TylerLeonhardt @alexdima (have a look at my explanation) |
But aren't you just adding it to the (not-to-do list)? Isn't it best to take time and work on it to fix it forever? It's obviously not great for you guys too to deal with the same issue again and again and again. Do JetBrains's products support RTL correctly? If it doesn't, it's a big win for vsCode. What about other editors? I'm on Telegram https://t.me/babakfp, I'll answer all of your questions, contact me anytime and I'll stay in contact as much as it takes to solve this problem. |
@babakfp That confusion is cleared up in later comments.
No, it's not. I would say that isn't even the main issue. There are actually a number of issues around this, e.g.:
And what makes this all worse, is that VS Code has a lot of custom positioning around cursor/selection placement that has to handle all of this. All of this is covered in various comments in that thread, and in linked issues. |
The #11770 issue It has become a basket that any problems related to RTL languages are putted into it There may be various different problems but on the same topic. Have you recorded the closed problems that may have different aspects of the problem? |
Yep. that's exactly what is happening. |
Maybe something like this for each line: The same happens on Telegram: |
😐 |
@babakfp Thank you for looping me in. I agree that #11770 has a confusing history. As I understand it, the issue you're describing has to do with VS Code either detecting the base line direction automatically (per Unicode BiDi algorithm) or being able to set the direction. #11770 does have some discussion of this, but the issues #65648, #65855, and #4994 are more concise and targeted. Those are all still open. Perhaps you'd want to continue the discussion there? I am with you that I hope these issues get put into the pipeline and resolved soon! |
This issue is a disaster, |
Hi there @alexr00 |
I'm sorry, you did a great job but can't you be a little more formal and talk about it professionally |
Hi @AhmedElTabarani |
@babakfp Thanks for pushing hard for this. I would like to report on it for the online magazine www.digitalorientalist.com. May I use the images you have posted here? Maybe you can contact me off GitHub - I can't immediately track you down but I think you should have no problem contacting me. |
Hi @lwcvl
Sure, feel free to use whatever I posted related to this topic🌼 |
Thank you, everyone🌼🌼 @ForrestKnight |
What da hell dude! |
This text
Most look like this:
Looks correct without that English word:
The text was updated successfully, but these errors were encountered: