Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: node2 - General bugbash #14341

Closed
2 tasks done
roblourens opened this issue Oct 25, 2016 · 1 comment
Closed
2 tasks done

Test: node2 - General bugbash #14341

roblourens opened this issue Oct 25, 2016 · 1 comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Oct 25, 2016

Effort: 3

There are a ton of little things that changed in the past month and it will be very helpful to do another general pass. Just spend a little time with it doing anything. At this point, basically anything that works in node-debug should also work in node-debug2.

From the previous testplan-item -

There are a million scenarios we need to support, so the most valuable thing you can do is grab any random Node project that you might have debugged with VS Code in the past, change "type" to "node2", and see what happens. If anything happens that isn't the same as "node", is it obvious to figure out what's wrong?

More specific things to try, don't need to do every single one:

Try some things that are checked off at microsoft/vscode-node-debug2#7
Ensure it kills the process when terminating a launch config, but not an attach
Set breakpoints before launching, and ensure they bind
In the main script, and in scripts that are loaded later
Look in the variables pane at different types and compare it to what you'd expect
Test very large arrays and other stress cases
It might get slow but it shouldn't crash
Test with and without sourcemaps
Attach config with a running process (start with --inspect=9229)

@roblourens
Copy link
Member Author

@mousetraps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants