Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a default workspace when opening a single folder may be confusing #143856

Closed
gregvanl opened this issue Feb 24, 2022 · 2 comments
Closed
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@gregvanl
Copy link

Testing #143456

It took me a while to notice that opening a folder on insiders.vscode.dev was actually adding the folder to a default workspace. As a VS Code desktop user, I would not have expected the folder to be parented to a workspace.

I was also surprised that opening another folder adds the new folder to the workspace instead of closing the previous folder and opening just the new folder.

The difference in behavior and introducing the workspace concept when opening a single folder may be confusing for current VS Code desktop users.

I also looked around for a Close Folder command and finally realized I needed to right-click on the folder node and run Remove Folder from Workspace to close the folder

@bpasero bpasero added the *as-designed Described behavior is as designed label Feb 24, 2022
@bpasero
Copy link
Member

bpasero commented Feb 24, 2022

This is unfortunately a technical limitation we had to workaround with the approach we use now. The issue is:

  • opening a folder currently requires a window reload in both desktop and web (in other words, opening a workspace is not possible without a reload)
  • opening a local folder from the web needs explicit user intent, so we cannot ask the user to open a folder and then reload the window

See also #136486, #35109

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @gregvanl and others