Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide editor.renderWhitespace "selection" option #1477

Closed
OlsonDev opened this issue Dec 19, 2015 · 30 comments
Closed

Provide editor.renderWhitespace "selection" option #1477

OlsonDev opened this issue Dec 19, 2015 · 30 comments
Assignees
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@OlsonDev
Copy link

Sublime Text has the option:

    // Set to "none" to turn off drawing white space, "selection" to draw only the
    // white space within the selection, and "all" to draw all white space
    "draw_white_space": "selection",

I would like to see selection added to list of possible values for editor.renderWhitespace. I find it incredibly useful.

While writing code, I prefer to not show whitespace. However, when I copy-paste code snippets, I like to know the whitespace matches the target document by simply selecting it (usually via Ctrl+A), not using the arrow keys or toggling a setting.

Thanks

@bpasero bpasero added the feature-request Request for new features or functionality label Dec 19, 2015
@bpasero bpasero added this to the Backlog milestone Dec 19, 2015
@bpasero bpasero added the editor label Dec 19, 2015
@bpasero
Copy link
Member

bpasero commented Dec 23, 2015

@alexandrudima fyi

@elad
Copy link

elad commented Jan 18, 2016

I feel bad commenting "+1" on this issue, especially after the open letter to GitHub, but there's no other way of letting you know how important this is to me without doing so. So +1. :)

@samal-rasmussen
Copy link

samal-rasmussen commented Dec 15, 2016

50 thumb ups atm, multiple duplicates, but no no movement on this for a year? Seems like a low hanging fruit ripe for the picking to me. Anybody?

@RomainLanz
Copy link

Hopefully this will be added in the next release!

@mignz
Copy link

mignz commented Dec 22, 2016

Taking a while... :(

@calebmosher
Copy link

This seems to be the main issue that is being tracked for this. Any update on when we can expect to see this feature in a future release?

@CoolGoose
Copy link

It would be great to have this, since it's valuable to know whitespace status in various cases including linting.

@ghost
Copy link

ghost commented Feb 23, 2017

+1

@spywhere
Copy link
Contributor

While we wait, I have create an extension explicitly for this issue. Please take a look.

@chmln
Copy link

chmln commented Apr 24, 2017

Shameless plug

For those who want sublime's tab+space rendering

see https://marketplace.visualstudio.com/items?itemName=chmln.better-whitespace

@spywhere
Copy link
Contributor

@chmln I don't want to inform about this for the sake of installation numbers on my extension but I believe you just derived my work there. Although I didn't specified any license in my repository. GitHub's default license for unlicensed repository is as followed...

screen shot 2560-04-24 at 08 36 07
(ref: Licensing a repository)

If you believe that it's totally all your hard work, could you prove it that it's yours?

If you just want to do a variant implementation, you could just PR on my extension as your extension do most things the same way as mine do.

@chmln
Copy link

chmln commented Apr 24, 2017

@spywhere I wouldn't like to derail this thread now and spam inboxes of all those who are subscribed here. Let's talk about it elsewhere

@alexdima
Copy link
Member

alexdima commented Jun 1, 2017

I just wanted to share a quick dirty hack:

	"editor.renderWhitespace": "all",
	"workbench.colorCustomizations": {
		"editorWhitespace.foreground": "#ffffffff" // <-- use here the theme's background color
	}

It isn't really the same, but not super bad either:
1477

@Stuk
Copy link

Stuk commented Aug 2, 2017

In addition to the above, I had to set editorIndentGuide.background so that my indent guides didn't disappear too (with Oceanic theme):

    "workbench.colorCustomizations": {
        "editorWhitespace.foreground": "#1B2B34", // theme background
        "editorIndentGuide.background": "#65737E" // indent guide color
    }

@volosovich
Copy link

Hello,
Does exist any chance to add this small feature in future releases?
Really small option, but need to use whole extention for that.
A lot of thanks to @chmln for it

@alexdima alexdima added editor-rendering Editor rendering issues and removed editor editor-core Editor basic functionality labels Nov 24, 2017
@ramya-rao-a ramya-rao-a modified the milestones: March 2018, Backlog Mar 20, 2018
@janniks
Copy link

janniks commented Mar 21, 2018

+1 @elad

@emkayy
Copy link

emkayy commented Apr 20, 2018

It has been moved back several times now ...!
@ramya-rao-a when will it actually be included?

@tbrebant
Copy link

Yet another +1

@DarkRoastOtter
Copy link

While the boundary setting is nice, having a proper selection render would be truly ideal, definitely support this too! +1

@mraffonso
Copy link

This is especially useful when collaborating who aren't very pedantic when it comes to whitespace. +1

@komlenic
Copy link

+1

1 similar comment
@PymZoR
Copy link

PymZoR commented Oct 9, 2018

+1

@rodrigogonegit
Copy link

Any news?

@kanlukasz
Copy link

Until this is not fixed, we can use:
https://marketplace.visualstudio.com/items?itemName=spywhere.whiteviz
Anyway, i think VS Code Team should make it in standard

@gsemet
Copy link

gsemet commented Mar 13, 2019

thank @kanlukasz :)

@Otiel
Copy link

Otiel commented Mar 13, 2019

Until this is not fixed, we can use:
https://marketplace.visualstudio.com/items?itemName=spywhere.whiteviz

Any advantage compared to using the tip shared by @alexandrudima?

	"editor.renderWhitespace": "all",
	"workbench.colorCustomizations": {
		"editorWhitespace.foreground": "#ffffffff" // <-- use here the theme's background color
	}

1477

@kanlukasz
Copy link

kanlukasz commented Mar 13, 2019

Any advantage compared to using the tip shared by @alexandrudima?

In this plugin you have some extra options, for example - changing this arrows to a straight long lines

Edit:

There is one small visual error in this plugin - spywhere/vscode-whiteviz#10

@RMacfarlane
Copy link
Contributor

The setting will be available in tomorrow’s VS Code Insiders, which you can download here if you want to try it out: https://code.visualstudio.com/insiders/. It will be part of our next release in August. Thanks!

@spywhere
Copy link
Contributor

Nice job! I'll update the extension to encourage this change accordingly then. 😄

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests