Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/microsoft/vscode-file-downloader appears abandoned #147807

Closed
pcj opened this issue Apr 21, 2022 · 5 comments
Closed

https://github.com/microsoft/vscode-file-downloader appears abandoned #147807

pcj opened this issue Apr 21, 2022 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@pcj
Copy link

pcj commented Apr 21, 2022

Numerous documentation recommends using https://github.com/microsoft/vscode-file-downloader in conjunction with https://github.com/microsoft/vscode-file-downloader-api for extension authors that need the capability to download binary artifacts.

This extension unfortunately does not seem to have an active maintainer. Specifically, this extension is affected by nodejs/node#40191 and needs a fix. There is an open PR microsoft/vscode-file-downloader#32 that needs attention from someone with rights on this repository.

Anyhow, it leads to a degraded experience for vscode extensions that depend on this one, I don't have the stats of how many.

Sorry to raise it here, hoping someone from the vscode team will see it and can triage the right person.

Thanks in advance!

@isidorn
Copy link
Contributor

isidorn commented Apr 22, 2022

@pcj thanks for raising this issue. Can you share some of that numerous documentation that recommends this extension?

On the VS Code side we can mark that extension as deprecated.

@isidorn isidorn added the info-needed Issue requires more information from poster label Apr 22, 2022
@prb28
Copy link

prb28 commented Apr 22, 2022

@isidorn , thanks for this info.
What is the preferred way to download files from an extension?
Is there some example somewhere?
Can the code in this extension be used as a starting point to integrate it in an extension?

@isidorn
Copy link
Contributor

isidorn commented Apr 22, 2022

@prb28 I suggest to join the extension author community here and ask those questions
https://vscode-dev-community.slack.com

@prb28
Copy link

prb28 commented Apr 22, 2022

@prb28 I suggest to join the extension author community here and ask those questions

https://vscode-dev-community.slack.com

Thanks

@pcj
Copy link
Author

pcj commented Apr 23, 2022

@isidorn I'll look around to find examples of the recommendation I mentioned. However, the existence of https://github.com/microsoft/vscode-file-downloader having 321K installs and https://github.com/microsoft/vscode-file-downloader-api gives it an appearance of solidity.

Looks like @daniv-msft merged that PR (thanks!) so hopefully we're all good for now.

I'll go ahead and close this, thanks for your attention!

@pcj pcj closed this as completed Apr 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants
@pcj @deepak1556 @isidorn @prb28 and others