Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently opened workspaces is not shown in all windows #148155

Closed
sandy081 opened this issue Apr 26, 2022 · 4 comments
Closed

Recently opened workspaces is not shown in all windows #148155

sandy081 opened this issue Apr 26, 2022 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #148063

I have opened couple of remote repositories. In the window where remote repository is opened, picker from remote indicator shows recently opened repositories. Open a window (empty or local folder), picker from remote indicator does not show recently opened repositories

image

@joyceerhl
Copy link
Collaborator

This works for me with the latest pre-release I just published. It wouldn't have worked in an earlier version of Remote Repos--would you mind ensuring that you are on the latest of everything and try again please?

image

@joyceerhl joyceerhl added the info-needed Issue requires more information from poster label Apr 26, 2022
@sandy081
Copy link
Member Author

I can still repro it with this version

image

BTW I am testing it on Desktop

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member and removed info-needed Issue requires more information from poster labels Apr 27, 2022
@joyceerhl joyceerhl added this to the April 2022 milestone Apr 27, 2022
@joyceerhl
Copy link
Collaborator

joyceerhl commented Apr 27, 2022

This happens because the built-in GitHub extension already registers a remote source provider, and to avoid duplicates, I avoided registering a GitHub remote source provider in RemoteHub if the GitHub extension was active. However, since that provider was also providing the recent sources, this led to desktop having the builtin GitHub extension's remote source provider (which of course doesn't know anything about recent sources).

I pushed a change to always register the GitHub remote source provider, so that the recent remote sources do show up. The problem is that on desktop we now have two "Open Repository from GitHub" options.

I think the recent sources should continue to be provided by Remote Repositories, since that isn't something the builtin GitHub extension knows about, but we should deduplicate the GitHub remote source provider by bringing the builtin GitHub extension's remote source provider up to parity with the Remote Repositories provider, and then removing the latter. This would require a change in the git-base extension to allow a provider to contribute recent sources but not implement getSources, and this provider would also not get a quickpick item in the list of remote sources. This might require us to introduce the notion of a RecentRemoteProvider after all. What do you think @lszomoru?

@joyceerhl joyceerhl added the unreleased Patch has not yet been released in VS Code Insiders label Apr 27, 2022
@rzhao271 rzhao271 added the insiders-released Patch has been released in VS Code Insiders label Apr 29, 2022
@sandy081 sandy081 added the verified Verification succeeded label May 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@lszomoru @rzhao271 @sandy081 @joyceerhl and others