Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook language detection runs too aggressively #148762

Closed
JacksonKearl opened this issue May 5, 2022 · 2 comments · Fixed by #148761
Closed

Notebook language detection runs too aggressively #148762

JacksonKearl opened this issue May 5, 2022 · 2 comments · Fixed by #148761
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders languages-guessing Language guessing issues verified Verification succeeded
Milestone
May 2022

Comments

@JacksonKearl
Copy link
Contributor

The candidate fix for #148220 was to just disable language detection in notebooks by default. With a bit more time to work on it, a better solution should be derived.
@JacksonKearl JacksonKearl self-assigned this May 5, 2022
@JacksonKearl JacksonKearl mentioned this issue May 5, 2022
Merged
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug languages-guessing Language guessing issues labels May 5, 2022
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@byehack byehack mentioned this issue May 8, 2022
Closed
2 tasks
@byehack
Copy link

byehack commented May 8, 2022

is this fix insider released?

@JacksonKearl
Copy link
Contributor Author

@byehack is it now :)

@mjbvz mjbvz added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders languages-guessing Language guessing issues verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Improve notebook language detection CPU microsoft/vscode
4 participants
@JacksonKearl @mjbvz @byehack and others