GIT_EDITOR set without asking and throwing error when I try amend a commit

[Tyriar]

Normally I would use git commit --amend and fix the error in vim, from today I see this now:

I see setting $GIT_EDITOR by default was intentional in #95266, I don't think we should do that; if a user is committing via the command line (not integrated git), you shouldn't touch the git commit editor unless opted into.

The actual error here is because the path is wrong and is missing gitEditor/:

C:\Users\Daniel\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\gitEditor\scripts\git-editor.bat

Version: 1.68.0-insider (user setup)
Commit: 528ee1a
Date: 2022-05-26T05:16:43.433Z
Electron: 17.4.4
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.22000

[Tyriar]

Also I see `git.useEditorAsCommitInput's default value is false and I don't have it set 🤷

[bpasero]

Why do we need to explicitly set the git editor, isn't this something a user can configure in git settings to use VSCode as git editor?

[IllusionMH]

Related #150463

But I also agree that it looks strange to override expected config if git used in integrated terminal.
Unable to test because of an error, but wouldn't it also break interactive GitLens rebase editor?

[Tyriar]

FYI I think the fact it was on was a bug #150487, I don't have strong feelings about the setting itself.

[lszomoru]

@bpasero, while users can indeed explicitly set their git editor to be VS Code, we are trying to make it easier for users to do so. The motivation/pattern here matches the one that drove the implementation of git askpass in VS Code. Happy to chat more if you want about this.

[lszomoru]

Closing the issue as the GIT_EDITOR environment variable should only be set if git.useEditorAsCommitInput is enabled.

[bpasero]

Yeah understood, I came to the same conclusion about making it easier for users.

[joyceerhl]

git.useEditorAsCommitInput doesn't seem to be a setting anymore, are there other steps to verify this?

[Tyriar]

@joyceerhl my issue is definitely fixed because the feature was reverted, not sure if it's getting added back this release with fixed setting @lszomoru?

[lszomoru]

The feature will be added back for the next release, and the GIT_EDITOR will only be set if git.useEditorAsCommitInput is enabled. I would suggest that we mark this issue as "verified" and will reopen it in case this will still be a problem after the feature is added back.