-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Commit error after June VS Code update #154449
Comments
I have the same issue. I can commit by doing "git commit -m "message for the commit". I guess the issue is that when you just do "F1 - > commit" it doesn't give you the option to supply a message and therefor you get the error " Please supply the message using either -m or -F option." |
After reading the documentation I now understand the behavior :) |
I have been trying to reproduce this issue in-house without much luck. Would you be able to create a gif recording (https://gifcap.dev) while reproducing the issue? Thank you very much in advance! |
ah thank you so much I have been trying to figure out how to fix this 500 error code for 2 days! Go figure all you have to do is untick a box.... |
@CryptoCherie, apologies for the caused inconvenience. While toggling the setting to disable the new flow is a valid workaround, I do want to get to the bottom of the root cause and fix it. Are you able to reproruce the 500 error in all repositories or only some? If only in some, is there anything specific about those repositories? Could you please share a recording (https://gifcap.dev) when you reproduce the issue? Thank you! |
I get this pressing the new commit button with no text in the textbox using a remote environment where the other side has git version 2.7.4. It hangs indefinitely, and to recover I need to reload the window. Ideally, if there I'd no text I'd get a pop-up warning like if I try to commit with no staged changes. |
@MarkAHamann, thanks for the additional details. |
Remote-ssh. Windows 10 at my desk connected to Linux beast somewhere in the building. |
Also, it seems to be opening .git/COMMIT_EDITMSG into my open editors. Empty, of course, because I didn't have a commit message in the text box. |
@MarkAHamann, if you do not specify a commit message in the input than VS Code will open the |
Hmm... I hadn't really noticed that new file opening up until later. I just did a commit, got the open file, added a message, hit ctrl-s to save, and now it's still hung indefinitely. Wait, I just hit the little x to close the editor and it completed. OK, I see what's going on now. Working as expected (though with new expectations). Pebcak. |
[makz159] Thanks a lot my friend @makz159, I could solved this bug c. |
@lszomoru See attachment for my gif recording while I reproduce the error. I've got a fairly streamlined setup. I don't have many VS Code extensions beyond Python, Jupyter and Git History. I haven't done any further attempts to rectify the problem since I filed the report last night; however, I now realize the problem seems to stem from my neglect to include a comment with my Commit. It would be nice if VS Code could fail more gracefully though. Thanks for your support. |
@lszomoru I confirmed the Commit proceeds successfully if I simply enter a message in the empty Message field directly above the Commit button before I hit the Commit button. Do you want me to close this ticket or leave it open to track graceful resolution of the error reporting? |
Provide a message or text while committing Files |
@Schlermie, thank you very much for the recording. We should keep the issue opened as this is clearly a problem that I have to address. One should be able to go through the commit flow even if a commit message is not provided as illustrated in the release notes. |
@Schlermie, could you please reproduce the problem again, and then invoke the |
I have further looked at the code and my current hypothesis is that we are failing to open the @Schlermie, could you please check the version of git that you are using by running |
Could #154503 be related to this one? |
@lszomoru See attachment for my error reproduction, followed by invoking the Developer Tools. |
'git --version' returns this: |
|
Thanks a million, this recent change they made was driving me crazy for the past 2 days. I use custom hot keys to commit and push my code, so I expect the text box to appear and ask for a message. This post just saved my sanity. |
Quick update on this issue. I was able to track down the root cause of this failure to cases in which the repository path contains spaces on the path. The fix will be included in tomorrow's Insiders release (2022-07-12), and the Stable recovery release scheduled for later this week. Apologies for the inconvenience caused. |
@lszomoru closing this for verification since the associated PR was merged. |
worked for me. thanks. |
@lszomoru I have the same problem with a repository without spaces on the path when I try to do a Commit Staged (Amend) as the message is empty. If I un-check the Git: Use Editor As Commit Input everything works as expected. This is the git log output:
NOTE: VSCode v1.69.0 running in a Workspace in a Remote Development Docker container. |
@rubensa, are you able to reproduce the problem with the latest Insiders release? |
@lszomoru It works. |
Thanks @makz159 , its resolved at my end |
Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:
This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms]
[2022-07-08T04:36:17.835Z] Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.
[2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms]
[2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Extensions (6)
A/B Experiments
The text was updated successfully, but these errors were encountered: