Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate theme color(s) for comments in overview ruler / scrollbar #156653

Closed
hermannloose opened this issue Jul 29, 2022 · 2 comments
Closed
Assignees
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@hermannloose
Copy link
Contributor

Decorations for lines with review comments are currently drawn in the center lane of the overview ruler / scrollbar using the same color as the editor gutter decorations for commenting ranges, editorGutter.commentRangeForeground (source). The bright gray used for the editor gutter decorations is not very distinct from the color used for search results or occurrences of the current token under the cursor, which are drawn in the same lane.

We would like the flexibility of a new theme color (which can by default inherit from editorGutter.commentRangeForeground) to allow users to have the comments be more noticeable, while not affecting the editor gutter decorations.

As #127473 is being finalized, it might also make sense to go for two new theme colors right away, one for unresolved comment threads (which users likely want more prominent) and one for resolved comment threads (which can probably be more subtle), e.g. editorOverviewRuler.unresolvedComment and editorOverviewRuler.resolvedComment.

Alternatively, if new colors should be kept to a minimum, we could also work with the overview ruler reusing editorCommentsWidget.unresolvedBorder and editorCommentsWidget.resolvedBorder, although that starts to erode the scope that those color names suggest.

cc @alexr00 @laurentlb @albertelo

@hermannloose
Copy link
Contributor Author

In the example screenshot, bright gray are comments, slightly darker gray are token occurrences.

Screen Shot 2022-07-29 at 11 30 26

For our internal user base being used to "unresolved" = "warning yellow", we would like to highlight unresolved comments in the overview ruler with a similar treatment, but this would make the editor gutter decorations misleading, as not every comment glyph widget in the editor gutter is for an unresolved comment.

I assume that on a technical level, CommentGlyphWidget will need information about the CommentThreadState of the comment for the lineNumber it's being rendered at anyway to pass to the overview ruler decoration, so while we are at it, we could consider two additional colors to draw CommentGlyphWidget in a color that reflects resolved / unresolved state.

@alexr00 alexr00 assigned alexr00 and unassigned rebornix Jul 29, 2022
@alexr00 alexr00 added feature-request Request for new features or functionality comments Comments Provider/Widget/Panel issues labels Jul 29, 2022
@alexr00 alexr00 added this to the Backlog milestone Jul 29, 2022
@alexr00
Copy link
Member

alexr00 commented Jul 29, 2022

@hermannloose this is a reasonable request, but not something we're likely to work on soon. I would accept a PR if you wanted to make one.

@alexr00 alexr00 modified the milestones: Backlog, May 2023 May 9, 2023
@alexr00 alexr00 closed this as completed May 22, 2023
@alexr00 alexr00 added the verification-needed Verification of issue is requested label May 26, 2023
@roblourens roblourens added the verified Verification succeeded label May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants