source.fixAll: true removes unreachable code

[jeffrson]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.70.2
• OS Version: Windows 10

Steps to Reproduce:

1. Use this settings.json

{
  "editor.codeActionsOnSave": {
    "source.fixAll": true
  }
}

2. Edit a file

console.log(1)
return
console.log(2)

3. Press Ctrl-S to save - everything after 'return' is removed.

AFAICT, VSCode should not delete code like this. Yes, I could "source.fixAll": false, but this would interfere with real autofixes.
Also, there's no hint to be seen, that anything might be wrong with the code - Ctrl-. shows "No code actions available". The "fix" cannot be disabled.

BTW, is there any documentation, what "source.fixAll" is supposed to do without any extension that makes use of it?

Obviously this is a very annoying bug, since you cannot simply "disable" following parts of the code for testing.

[VSCodeTriageBot]

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

[jeffrson]

Sorry - I can't believe you're closing just by "behavior is how it is expected to work" without further explanation regarding my points.

IMO, inserting "return" just to disable part of code temporarily is not too uncommon of a workflow (much shorter and quicker than commenting). Then, "save" removes all this only temporarily disabled code. This way, the source code is heavily changed in its overall meaning what never should be done by any "autocorrection".

Also, there's no indication of some "error" that should be corrected. So removing the code is quite unexpected.

Furthermore, there is no documentation what "source.fixAll: true" actually does. And there's no way to configure what it does.

I now have '"source.fixAll": false', but I think this may change how "real autofixes" (eslint, prettier) behave.

[nghieptiki]

Same issue source.fixAll: false doesn't solve the problem.