Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive window should be more aligned with the accessibility experience of VS Code #161925

Closed
isidorn opened this issue Sep 27, 2022 · 2 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug interactive-window

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

Testing #161850

Since the interactive window is using a lot of custom UI this means that our accessibility users are maybe not used to the interaction it offers.
I tested the improved keyboard navigation in the test plan and it works as expected, but I think we need to take a step back and look at the bigger picture of the interactive window.

For example:

  • Can we learn from the Debug Console and Terminal and have similar keyboard interaction as they do since this is something that our users are already familiar with
  • Can we use the same navigation as we do in other VS Code toolbars? It is only one tab stop, and left/right are used to navigate through actions
  • How do we move focus to the top level toolbar? Does that top level toolbar behave like other toolbars in vscode? Does it have the required aria roles?
  • etc...
@amunger amunger added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues interactive-window labels Dec 6, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Dec 9, 2022
@r3m0t
Copy link
Contributor

r3m0t commented May 10, 2023

Hi, I'm trying to scroll the last output on my interactive (it has a scrollbar). Nothing works, I started with "Interactive Window: Focus History", then I did Ctrl+DownArrow (notebook.cell.focusInOutput), this doesn't seem to do anything in Interactive window.

If I click in the output, PageDown and PageUp are mapped to list.focusPageDown and list.focusPageUp which scrolls the interactive window instead of the specific output.

@amunger
Copy link
Contributor

amunger commented Nov 20, 2024

We've done some work on this for the native REPL through #209140, and we'll keep tracking feedback through new issues. Jupyter's interactive window should be migrated to the notebook backed REPL editor to get the full set of a11y functionality

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug interactive-window
Projects
None yet
Development

No branches or pull requests

4 participants