Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.showNotebookDocument fails for Interactive Window with "Notebook Editor creation failure for document [object Object]" #163469

Closed
amunger opened this issue Oct 12, 2022 · 2 comments
Closed

window.showNotebookDocument fails for Interactive Window with "Notebook Editor creation failure for document [object Object]" #163469

amunger opened this issue Oct 12, 2022 · 2 comments
Assignees
@lramos15
Labels
verified Verification succeeded
Milestone
October 2022

Comments

@amunger
Copy link
Contributor

amunger commented Oct 12, 2022

this is causing Interactive window restore to fail: microsoft/vscode-jupyter#11574

  1. set "interactiveWindow.restore": true
  2. run a cell from a .py file to create an interactive window
  3. reload VS Code
  4. run a cell from the same .py file to re-use the interactive window
    🐛 a new editor is created and fails to open
@amunger amunger mentioned this issue Oct 12, 2022
Closed
@amunger amunger linked a pull request Oct 12, 2022 that will close this issue
don't re-register an editor for the interactive window #163489
Closed
@lramos15
Copy link
Member

Is this finished via #163710?

@amunger amunger added this to the October 2022 milestone Oct 31, 2022
@amunger
Copy link
Contributor Author

amunger commented Oct 31, 2022 •
edited
Loading

yes, closing

@amunger amunger closed this as completed Oct 31, 2022
@amunger amunger added the verified Verification succeeded label Oct 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

Labels
verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

don't re-register an editor for the interactive window amunger/vscode
2 participants
@amunger @lramos15