Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook preload scripts load after the renderer scripts #164304

Closed
DonJayamanne opened this issue Oct 21, 2022 · 4 comments · Fixed by #164406 or #164667
Closed

Notebook preload scripts load after the renderer scripts #164304

DonJayamanne opened this issue Oct 21, 2022 · 4 comments · Fixed by #164406 or #164667
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Insider
  • OS Version: N/A

Steps to Reproduce:

  • Create a renderer with preload scripts using the new contribution notebookPreload
    • Add a console.log into this script
  • Create an output with HTML in a notebook
    • Add a console.log into the output HTML
  • Keep the notebook open and reload VS Code
  • You'll notice that the output HTML script is executed first

I.e. the preloads are loaded after the renderer scripts.

@DonJayamanne
Copy link
Contributor Author

Closing this as I can no longer repro this issue, possible i had an older version of insiders or the like.

@DonJayamanne DonJayamanne reopened this Oct 24, 2022
@DonJayamanne DonJayamanne added this to the October 2022 milestone Oct 24, 2022
@DonJayamanne
Copy link
Contributor Author

I can still repro this issue, I think you should reload vscode with all editors closed, then open the notebook.
Seems to be a timing issue with activation of the extensions or the like.

@mjbvz this blocks microsoft/vscode-jupyter#6404 which was on the iteration plan, it kinda works. Kind of based on the timing of the loading of the pre-load scripts.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug author-verification-requested Issues potentially verifiable by issue author labels Oct 24, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 24, 2022
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@DonJayamanne, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version a803dc3 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@DonJayamanne DonJayamanne self-assigned this Oct 26, 2022
@DonJayamanne
Copy link
Contributor Author

/verified

@vscodenpa vscodenpa added verified Verification succeeded and removed author-verification-requested Issues potentially verifiable by issue author labels Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
3 participants