Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win/Linux: detect real casing of workspace paths #16570

Closed
roblourens opened this issue Dec 6, 2016 · 5 comments
Closed

Win/Linux: detect real casing of workspace paths #16570

roblourens opened this issue Dec 6, 2016 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@roblourens
Copy link
Member

roblourens commented Dec 6, 2016

In insiders, I had a workspace opening with a lowercase workspaceRoot path, so that file paths were reported as lowercased, and ${workspaceRoot} in a launch config was replaced with a lowercase version which is how I noticed. I opened and closed vscode several times and it persisted. And it persisted through opening that folder again with the 'recently opened' list. I opened the folder again using cmd+o, and then it had the correct casing. I assume that the list of recently opened folders got the lowercased path somehow. Any idea how it could have happened? It's not reproing anymore unfortunately.

I debugged it as far as the function startup in main.ts and saw that it was lowercased at that point.

Should be uppercased /Users
image

@bpasero
Copy link
Member

bpasero commented Dec 6, 2016

@roblourens the workbench is using whatever path you give it, since Windows and OSX are case insensitive, lowercase paths are working. Detecting the correct case from a lowercase variant is very expensive and that is why we do not have code in place to do it, though we could add it.

@bpasero bpasero added the feature-request Request for new features or functionality label Dec 6, 2016
@bpasero bpasero removed their assignment Dec 6, 2016
@bpasero bpasero changed the title Workspace path is lowercase Win/Linux: detect real casing of workspace paths Dec 6, 2016
@roblourens
Copy link
Member Author

I see that I can do code FOO and open a folder, 'foo'. I didn't do anything like that though. Eh, I think what I need to do is detect this in the debug adapter and write a warning, which node-debug does. The debug adapter is not case-sensitive but Chrome is.

@roblourens
Copy link
Member Author

This happened again. No clue why, I'm not doing anything out of the ordinary.

Where are the 'Open recent' paths stored?

@roblourens
Copy link
Member Author

Mystery solved, it was hot exit

@bpasero
Copy link
Member

bpasero commented Jan 4, 2017

#12448

@bpasero bpasero closed this as completed Jan 4, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants