Test CommentThreadState API

[alexr00]

Refs: #127473

• anyOS @rzhao271
• anyOS @hediet

Complexity: 5

Create Issue

---

The CommentThreadState API has been finalized:

vscode/src/vscode-dts/vscode.d.ts

Lines 15225 to 15231 in fcb503b

	/**
	* The state of a comment thread.
	*/
	export enum CommentThreadState {
	Unresolved = 0,
	Resolved = 1
	}

vscode/src/vscode-dts/vscode.d.ts

Lines 15290 to 15293 in fcb503b

	/**
	* The optional state of a comment thread, which may affect how the comment is displayed.
	*/
	state?: CommentThreadState;

Take a look at the API and verify that the inline documentation makes sense. Then, try out the API. One easy way to try the API is to use the comments extension sample and instead of adding a "pending" label to the comment you could set the comment thread state to Unresolved:

https://github.com/microsoft/vscode-extension-samples/blob/8431b4978c73721adb1edb3571063bfada509e7a/comment-sample/src/extension.ts#L46-L48

Verify

• that you can see a difference in the UI treatment of resolved/unresolved comments in the Comments view.
• that when you update the comment thread state it is reflected in the Comments view.

[DonJayamanne]

@alexr00 not sure how I'm supposed to get the latest vscode.d.ts files,
wont i need to get the proposed API enabled to test this, which means I'm really testing the proposed API at this stage?
I.e. i cannot really verify whether its stable or not until the npm package has been published (@types/vscode) with the latest bits.

Please could you provide instructions on how I could get the vscode.d.ts files to test this, also, should I be enabling proposed-api in the launch.json?

[rzhao271]

It seems to me that the default state of the thread is Unresolved, but could that be clarified in the API docs?

Other than that, LGTM

[alexr00]

@DonJayamanne I usually just copy the vscode.d.ts file over for testing finalizations.

@rzhao271 the default state is neither unresolved no resolved so as to preserve the existing behavior for comments.

[hediet]

npx vscode-dts main downloads the latest vscode.d.ts!