extUri.relativePath returns wrong value if the path has UTF characters

[sandy081]

const actual = path.win32.relative('C:\\Users\\İ\\.vscode-insiders\\extensions', 'C:\\Users\\İ\\.vscode-insiders\\extensions\\ms-vscode.cpptools-1.14.3-win32-x64');
		assert.strictEqual(actual, 'ms-vscode.cpptools-1.14.3-win32-x64');

[bpasero]

Relevant upstream issue: nodejs/node#27534
And suggested PR: nodejs/node#27662

I am not entirely convinced we should take a change here that was not accepted in node.js. We try to stay identical to node.js behaviour with our path library for good reason so that there is identical interop.

I would close this "as designed".

[BridgeAR]

It just got fixed in Node.js and should be released soon in newer versions

[bpasero]

We will monitor upstream and pull it in once available for us.