Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.workspace.findFiles() case insensitive on Windows ? #17851

Closed
buzzzzer opened this issue Dec 27, 2016 · 6 comments
Closed

vscode.workspace.findFiles() case insensitive on Windows ? #17851

buzzzzer opened this issue Dec 27, 2016 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Milestone

Comments

@buzzzzer
Copy link

  • VSCode Version: 1.8.1
  • OS Version: Windows 10

vscode.workspace.findFiles should be case insensitive on windows ?
Writing in the extension:

var searchPattern = "**/sample.ini";
var files = vscode.workspace.findFiles(searchPattern, "");
files.then((value) => {
 // do something
}, 
(reason) => {
    console.log(reason);
});

how can I find Sample.ini, SAMPLE.ini or SamPLe.iNi ?
In fact in windows environment it is the same file...

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jan 12, 2017

The C++ debugger extension also is hitting the same problem when the user opens a file via the Explorer in one case and it opens a duplicate file with a 2nd casing on Windows (they say it's VS Code's fault). Please fix VS code so that it understands that Windows is case insensitive for files so it doesn't open 2 of the same ones, which causes things like breakpoints and bookmarks to be attached to only one of the files, which is confusing.

@roblourens
Copy link
Member

@sean-mcmanus I think that issue would be covered by #12448

@roblourens
Copy link
Member

@chrmarti Are you looking at this for January or should I take a look? Making it a case-insensitive search seems like the right thing to do.

@chrmarti
Copy link
Collaborator

I'm unlikely to get to this for this milestone. If you get a chance to look into this, could you check if all usages of glob.ts need to be case-insensitive on Windows? It might make sense to have it as an option that is passed in to glob.ts depending on that.

@roblourens roblourens modified the milestones: Backlog, January 2017 Jan 23, 2017
@chrmarti chrmarti added search Search widget and operation issues workbench bug Issue identified by VS Code Team member as probable bug and removed workbench labels Apr 17, 2017
@roblourens
Copy link
Member

Related: #10633

@roblourens
Copy link
Member

roblourens commented Sep 12, 2018

This would be handled with #10633

@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants