Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI build faster #178692

Closed
joaomoreno opened this issue Mar 30, 2023 · 1 comment · Fixed by #184545
Closed

Make CLI build faster #178692

joaomoreno opened this issue Mar 30, 2023 · 1 comment · Fixed by #184545
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@joaomoreno
Copy link
Member

Not only is the CLI stage the current bottleneck for our build's first stage, it also keeps a lot of agents busy as it runs. We should look into speeding it up. An obvious first step is to cache the target folder... maybe even use something like sccache.

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Mar 30, 2023
@joaomoreno joaomoreno changed the title Make CLI build faster by leveraging caches Make CLI build faste Mar 30, 2023
@joaomoreno joaomoreno changed the title Make CLI build faste Make CLI build faster Mar 30, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 7, 2023
@vscodenpa vscodenpa added this to the June 2023 milestone Jun 7, 2023
@connor4312
Copy link
Member

connor4312 commented Jun 7, 2023

sccache didn't end up being that useful. It seemed like maybe a 10% time reduction, but these are also pretty noisy, so it's hard to tell.

Instead I opted to only run a dev build with clippy for main's CI, which is much faster than a full optimized production build. Real production builds are unchanged, but I think these are a much lesser concern since they only run ~once a day.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants