Notebook cell editor 'is not accessible at this time'

[joyceerhl]

While testing #180470

1. Enable screenreader
2. Click into notebook cell
3. 🐛 hear 'the editor is not accessible at this time'

[meganrogge]

That's coming from here. @joyceerhl were you in Screen reader optimized mode?

vscode/src/vs/editor/browser/controller/textAreaHandler.ts

Lines 544 to 555 in 5ff3aa8

	return '';
	}
	private _getAriaLabel(options: IComputedEditorOptions): string {
	const accessibilitySupport = options.get(EditorOption.accessibilitySupport);
	if (accessibilitySupport === AccessibilitySupport.Disabled) {
	return nls.localize('accessibilityOffAriaLabel', "The editor is not accessible at this time. Press {0} for options.", platform.isLinux ? 'Shift+Alt+F1' : 'Alt+F1');
	}
	return options.get(EditorOption.ariaLabel);
	}
	private _setAccessibilityOptions(options: IComputedEditorOptions): void {

[joyceerhl]

No I just had my screen reader turned on from outside VS Code, and VS Code didn't ask me to enable screen reader optimized mode (although all the verbosity hints were picked up correctly)

[meganrogge]

Then the root of this bug is we're not detecting your screen reader correctly cc @deepak1556

Which were you using? NVDA, JAWS, Narrator?

[joyceerhl]

After digging around in settings I think the problem is that I'd set "editor.accessibilitySupport" to "off" some time ago, so even though I had a screen reader attached, editor accessibility support wasn't enabled--but all the accessibility verbosity settings were still functional, so I didn't initially realize that I'd disabled editor accessibility support. Is there a real end-user scenario for turning accessibility support off?

[meganrogge]

Thanks for investigating. There is no benefit to turning accessibility support off when using a screen reader. So I think this can be closed unless you have a suggestion for different behavior @joyceerhl