Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large notebook output performance numbers #188778

Closed
isidorn opened this issue Jul 25, 2023 · 2 comments · Fixed by #209282
Closed

Large notebook output performance numbers #188778

isidorn opened this issue Jul 25, 2023 · 2 comments · Fixed by #209282
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-output

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 25, 2023

Testing #188699

Creating this issue to check if we are capturing data related to Notbook output performance. For example, how much time does it take for the output to be rendered. Do we see how our investment in this area has improved these numbers?

If we are not already doing that, we could be inspired by some startup perf numbers that VS Code is doing. Here's a dashboard as an example https://msit.powerbi.com/groups/2bb9c256-c8ed-47a3-b1be-ebf0c050fb85/reports/2f5bed71-2607-4e0c-8a83-d0f9de023342/ReportSection2a538e7da53fa84953d6?experience=power-bi

fyi @minsa110

@amunger
Copy link
Contributor

amunger commented Jul 25, 2023

good call, we have some info that we present to the user, but that doesn't appear to be accurate in these cases.
image

@isidorn
Copy link
Contributor Author

isidorn commented Jul 25, 2023

Yeah, I think what would be most useful is to have dashboards for us that can help drive us when we do perf work. @jrieken has all the details on what we do for VS Code, but I can also share some details if you think that would be helpful.

@amunger amunger added debt Code quality issues notebook-output labels Dec 5, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 1, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants