editor should not be dimmed when navigating search results

[meganrogge]

editor.mov

[Tyriar]

@andreamah is there any class or something other CSS class we could use to disable this opacity rule for the editor when a search is active?

vscode/src/vs/workbench/contrib/accessibility/browser/unfocusedViewDimmingContribution.ts

Line 49 in 91acb95

rules.add(`.monaco-workbench .editor-instance:not(:focus-within) .monaco-editor { ${filterRule} }`);

[andreamah]

editor.mov

this is loading for me as a 1-second video. could you re-attach the video? I'm not sure where that opacity rule is referenced in search.

[Tyriar]

@andreamah it's not referenced in search, it's a small workbench contrib that currently depends on terminal and editor. We also want to include search in the rule to ensure the editor with the active match also shows up, even when it's not focused.

[andreamah]

What are the repro steps to seeing the dimmed editor when viewing search results? I don't think I see it.

[meganrogge]

set accessibility.unfocusedViewOpacity and open the search panel, search for something and click through the results

[andreamah]

Ah, I see it now. Can we check for context keys? If hasSearchResult & searchViewletFocus, then don't dim the editor?

[Tyriar]

We could use IContextKeyChangeEvent.onDidChangeContext but that would involve setting up a listener and replacing the CSS. That's an option, but it would be preferable if there's something like .has-search-results. If that doesn't exist that's fine, we can go the event route.

[andreamah]

Sorry for the late reply on this. I don't think there's anything like .has-search-results since search uses the context key to make changes to the view. We could probably have to do a IContextKeyChangeEvent.onDidChangeContext for hasSearchResult

[vs-code-engineering]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

[Tyriar]

Merging into #236576

/duplicate