Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files need to ignore hash/query portion of URIs and only check for fsPath #19398

Closed
mjbvz opened this issue Jan 25, 2017 · 2 comments
Closed

Files need to ignore hash/query portion of URIs and only check for fsPath #19398

mjbvz opened this issue Jan 25, 2017 · 2 comments
Assignees
@bpasero
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone
Backlog

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 25, 2017

  • VSCode Version: 1.9

Repo:

Using an extension, try opening the same file multiple times but using different hash fragments: file.js#L10, file.js#L20, file.js#L30

I believe i used the vscode.open command

Bug
We open a new document in each case instead of switching to an already open copy.

I also notice multiple entries for the same file in the quick open view:

screen shot 2017-01-25 at 2 07 28 pm
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug workbench labels Jan 25, 2017
@mjbvz mjbvz changed the title vscode.open command opens multiple copy of same document when fragments differ vscode.open command opens multiple copies of same document when uri fragments differ Jan 25, 2017
@bpasero
Copy link
Member

bpasero commented Jan 26, 2017

This is a related issue to #12448

@bpasero bpasero added this to the Backlog milestone Jan 26, 2017
@bpasero bpasero changed the title vscode.open command opens multiple copies of same document when uri fragments differ Files need to ignore hash/query portion of URIs and only check for fsPath Jan 26, 2017
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Jan 26, 2017
@bpasero bpasero mentioned this issue Feb 7, 2017
Closed
2 tasks
@bpasero
Copy link
Member

bpasero commented Feb 7, 2017

Into #12448

@bpasero bpasero closed this as completed Feb 7, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bpasero @mjbvz