Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Show' vs. 'reveal' word in settings and commands #19441

Closed
borekb opened this issue Jan 26, 2017 · 7 comments
Closed

'Show' vs. 'reveal' word in settings and commands #19441

borekb opened this issue Jan 26, 2017 · 7 comments
Assignees
Milestone

Comments

@borekb
Copy link

borekb commented Jan 26, 2017

I got recently confused by this:

  • There is an explorer.autoReveal settings that implements this behavior: Provide an option to stop scrolling revealing active file in explorer #3062. I set that value to false.
  • To reveal the file in manually, I searched the command palette and indeed found "Reveal Active File in Windows Explorer".
  • I didn't notice that it mentions Windows Explorer specifically (my bad) and was confused by the resulting action.
  • I had somewhat hard time to find the right command. It turned turned out to be "Show Active File in Explorer".

I think that more consistent would be if reveal a file would always mean in VSCode's explorer while for opening anything externally, I'd use the word open. For example, "Open Active File in Windows Explorer".

@borekb
Copy link
Author

borekb commented Jan 26, 2017

Related issues:

@mousetraps mousetraps assigned bpasero and isidorn and unassigned bpasero and isidorn Jan 27, 2017
@bpasero bpasero added this to the February 2017 milestone Jan 27, 2017
@bpasero
Copy link
Member

bpasero commented Jan 30, 2017

Settled on "Reveal in Side Bar" across all OS. I left the other "Reveal in Finder" because it is also about revealing and not opening.

@antonydenyer
Copy link

In case anyone stumbles accross this the ID for it is:

workbench.files.action.showActiveFileInExplorer

Would be nice to have a full list of commands somewhere

@bpasero
Copy link
Member

bpasero commented Mar 17, 2017

If you open keybindings you see a list of unassigned keys at the bottom. We plan to improve the UX around keybinding editing for this milestone though to make this easier overall.

@antonydenyer
Copy link

antonydenyer commented Mar 17, 2017

Thanks @bpasero

I was looking for 'reveal' in the keybinding and was thinking this list isn't the full list. Then I ended up searching the code base for 'Reveal Active File in Side Bar' to find the ID.

@bpasero
Copy link
Member

bpasero commented Mar 17, 2017

What?

@Falieson
Copy link

"explorer.autoReveal": false,

is the command and setting to be added to your user settings.json

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants