Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Actions to Quickpicks, that modify behavior or filter content #194796

Closed
mahmoudsalah1993 opened this issue Oct 4, 2023 · 4 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@mahmoudsalah1993
Copy link
Contributor

Add the option to add actions or commands to the end of quickpicks. They should appear at the end of the options with a separator between the options and actions. The actions section shouldn't show checkbox in the canSelectMany mode. This allows the calling extension to toggle between 2 execution modes for example which filter options based on the mode.

In multi-select mode hitting accept while an action is in the quickpick's active items should resolve to the action only.

QuickPick Items kind (QuickPickItemKind can then have a type of default, separator and action.

Single-select mode:
image

Multi-select mode:
image

@TylerLeonhardt
Copy link
Member

At this time, the best thing you have in an extension is the ability to set a button on the quick pick that could toggle this behavior. That's what folks use today.

Folks have also added "actions" to the bottom of the quick pick list like you did, but in your case, you really need #141500 to do what you've mocked up there.

That said, I like what you've suggested as it allows us to be a bit more explicit in saying how these additional "actions" should behave... I also recall a feature request where folks wanted things pinned and I think these actions could be pinned to be always visible.

@TylerLeonhardt TylerLeonhardt added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Oct 4, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Oct 4, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants