Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Tree Sticky Scroll #199153

Closed
3 tasks done
benibenj opened this issue Nov 27, 2023 · 3 comments
Closed
3 tasks done

Test: Tree Sticky Scroll #199153

benibenj opened this issue Nov 27, 2023 · 3 comments

Comments

@benibenj
Copy link
Contributor

benibenj commented Nov 27, 2023

Refs: #161207

Complexity: 4

Create Issue


We added sticky scroll to all trees in vscode.

Try out sticky scroll on at least 3 different trees, one of them being contributed by an extension.

Examples: File Explorer, Outline View, Search View, SCM change files, Problems view, Debug panel, Testing View, Settings editor, GitHub PR extension, ...

Settings:

  • workbench.tree.enableStickyScroll: Enables/Disables sticky scroll for all trees (currently enabled by default)
  • workbench.tree.stickyScrollMaxItemCount: Maximum number of items in the sticky scroll widget

We make sure that the sticky scroll widget never fills more than 40% of the tree view. Try resizing the height of the view to test this.

Sticky Scroll Behaviour:

  • When pressing on a sticky scroll node, the tree reveals the real node under the the mouse cursor.
  • When pressing on a sticky scroll twisty, the tree collapses and reveals the real node under the the mouse cursor (It is not guaranteed that the real node can be revealed under the cursor as there might not be enough tree items after that node to scroll it in place).
  • When pressing on a sticky scroll action item, the action runs and the tree does not reveal the node (except if the action itself causes this to happen)
  • When right clicking a sticky scroll node, the context menu of that node appears.

Other Behaviour:

  • When using the arrow keys to navigate the trees the focused tree item can not be hidden behind the widget. (Same as when navigating the tree without sticky scroll, the focused item is always visible when using arrow keys
StickyScrollDemo.mp4
@Tyriar
Copy link
Member

Tyriar commented Nov 28, 2023

Very solid 👏

@lszomoru
Copy link
Member

Awesome work 👏🏻👏🏻👏🏻

@andreamah
Copy link
Contributor

Works well! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants