Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration to the terminal command SI tooltip #199170

Closed
Tyriar opened this issue Nov 27, 2023 · 2 comments · Fixed by #199357
Closed

Add duration to the terminal command SI tooltip #199170

Tyriar opened this issue Nov 27, 2023 · 2 comments · Fixed by #199357
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 27, 2023

We have a rough timestamp, but a duration would be quite easy to add here as well:

image
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. labels Nov 27, 2023
@Tyriar Tyriar added this to the Backlog milestone Nov 27, 2023
@Tyriar Tyriar self-assigned this Nov 27, 2023
@Tyriar Tyriar mentioned this issue Nov 27, 2023
Open
@hsfzxjy
Copy link
Contributor

hsfzxjy commented Nov 28, 2023

I'd like to work on this. To clarify, by "duration" do you mean "the amount of time this command being executed"?

@Tyriar
Copy link
Member Author

Tyriar commented Nov 28, 2023

@hsfzxjy yes, which is the amount of time between the command executed marker and command finished marker in commandDetectionCapability.ts in milliseconds

@hsfzxjy hsfzxjy mentioned this issue Nov 28, 2023
Merged
@Tyriar Tyriar modified the milestones: Backlog, February 2024 Jan 31, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 31, 2024
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Feb 16, 2024
@alexr00 alexr00 added the verified Verification succeeded label Feb 20, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2024
Development

Successfully merging a pull request may close this issue.

Add duration to the terminal command SI tooltip hsfzxjy/vscode
4 participants
@Tyriar @hsfzxjy @alexr00 @vscodenpa