Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement File Reading and parsing for unlimited file sizes #199922

Closed
maldag opened this issue Dec 4, 2023 · 3 comments
Closed

Implement File Reading and parsing for unlimited file sizes #199922

maldag opened this issue Dec 4, 2023 · 3 comments
Labels
editor-textbuffer Editor text buffer feature-request Request for new features or functionality

Comments

@maldag
Copy link

maldag commented Dec 4, 2023

As reading issue #167719 I'd be interested in a text editor backend which would be capable of reading files from a disk with sizes larger than systems memory. Looking at this https://github.com/vimpunk/mio repo, a possible implementation could be using memory mapped files. Would it be possible to include this kind of work as web assembly?

I found another piece which limits the file and line size for tokenizing. The comment says "LargeFileOptimization", but this would still be "tiny" concerning this approach.
https://github.com/microsoft/vscode/blob/main/src/vs/editor/common/model/textModel.ts#L347

It's probably there for a reason.
So I was thinking about:

  • Keep a part of the file in memory (using memory mapped files)
  • Index and tokenize the whole file (or to some extend)
    • How is the index and tokens stored in memory? Would this be an issue?
@alexr00 alexr00 assigned alexdima and unassigned alexr00 Dec 5, 2023
@alexdima alexdima added editor-textbuffer Editor text buffer feature-request Request for new features or functionality labels Dec 5, 2023
@alexdima alexdima removed their assignment Dec 5, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 5, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-textbuffer Editor text buffer feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants