Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering search for a selected text in detached editor not working properly #201579

Closed
DanTremonti opened this issue Dec 28, 2023 · 9 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.

Comments

@DanTremonti
Copy link

Triggering Search: Find in files, for a selected text in detached editor, using both command palette as well as the keyboard shortcut (Ctrl + Shift + F), works only the first time.

Does this issue occur when all extensions are disabled?: Did not check

  • VS Code Version: 1.85.0
  • OS Version: Ubuntu 20.04.6 LTS

Steps to Reproduce:

  1. Detach an editor to a new window
  2. Select text
  3. Trigger Search: Find in files
  4. Select some other text
  5. Trigger Search: Find in files again
@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@DanTremonti
Copy link
Author

The issue remains in v1.85.1 (I did not bother to upgrade to the patch version earlier as there was no mention of any fixes for this particular issue in the patch notes)

@danubie
Copy link

danubie commented Dec 28, 2023

I can prove as well, that the issue is in v1.85.1.

State 1
When working in detached window and using (Ctrl + Shift + F) the first time, the command bar opens the search dialog. If I have selected a string this is displayed as the search string.
Issue: Contrary when doing this in the default window, the input focus is not set to the search box but stays in the detached window.

State 2
The second time using (Ctrl + Shift + F), without closing the search dialog, no selected text get's pupulated in the search box.

State 3
When I close the search dialog after State 1 (by unfold the command bar) then the behaviour is back to 'State 1'

@andreamah
Copy link
Contributor

This should be a /duplicate of #193267

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 2, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
@DanTremonti
Copy link
Author

This should be a /duplicate of #193267

@andreamah could you please quote the mention of this bug in #193267? I'm unable to spot it.

@andreamah
Copy link
Contributor

andreamah commented Jan 3, 2024

On second thought, since this is more specific within enabling the search panel in a floating window, I'll leave it open for now. Also, I think the link I included wasn't completely related since this is just a detached editor, not a detached panel

@andreamah andreamah reopened this Jan 3, 2024
@andreamah andreamah added bug Issue identified by VS Code Team member as probable bug and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jan 3, 2024
@andreamah andreamah added this to the Backlog milestone Jan 3, 2024
@andreamah andreamah added the workbench-auxwindow Issues related to use of auxiliary ("floating") windows. label Jan 3, 2024
@bpasero
Copy link
Member

bpasero commented Jan 10, 2024

I think this no longer reproduces?

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@danubie
Copy link

danubie commented Jan 13, 2024

I checked it with tonights insider. It works fine now.
Thanks.

@bpasero bpasero closed this as completed Jan 13, 2024
@bpasero bpasero modified the milestones: Backlog, December / January 2024 Jan 13, 2024
@andreamah andreamah added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Development

No branches or pull requests

6 participants