Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer tmGrammar ownership #20160

Closed
mjbvz opened this issue Feb 8, 2017 · 1 comment
Closed

Transfer tmGrammar ownership #20160

mjbvz opened this issue Feb 8, 2017 · 1 comment
Assignees
Labels
plan-item VS Code - planned item for upcoming
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 8, 2017

No description provided.

@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Feb 8, 2017
@mjbvz mjbvz added this to the February 2017 milestone Feb 8, 2017
@kieferrm kieferrm mentioned this issue Feb 8, 2017
38 tasks
@aeschli
Copy link
Contributor

aeschli commented Feb 8, 2017

Thanks @mjbvz. Here's what to do.
Look at incoming issues regarding TypeScript & JavaScript coloring.

  • make sure the issue is complete and includes the sample code
  • reproduce the issue to see if it is still an issue
  • use the 'Developer: Inspect TM Scopes' command to look at the generated scopes to see if the issue is with the grammar or with our theming.
  • If it's a grammar issue, move to https://github.com/Microsoft/TypeScript-TmLanguage
  • If it is a theming issue, assign to me

From time to time, ideally a week before we start testing, check if an update of the grammar is available at https://github.com/Microsoft/TypeScript-TmLanguage/blob/master/TypeScript.tmLanguage

  • in extensions/typescript, run npm run update-grammars. This updates 3 files: the Typescript and the TypeScriptReact grammar as well as the JavaScript grammar. The JavaScript grammar is a copy of the TypeScriptReact grammar with scope names renamed from tsx to js.
    Check out update-grammars.js for details.
  • run scripts/test-integration.sh to run the grammar tests. The test takes the entries in test/colorize-fixtures and runs the grammar and theme rule matching on it. The result is written to test/colorize-result.
    If the written result is identical to the previous result, the test is green, else it is red. Use the Git diff viewer to see the differences in the result. If all changes make sense, accept the new result by committing it. If not, get back to the TypeScript grammar team or to me (for theming issues).
	{
		"c": ">=",
		"t": "source.ts meta.block.ts meta.class.ts meta.method.declaration.ts meta.block.ts keyword.operator.relational.ts",
		"r": {
			"dark_plus": "keyword.operator: #D4D4D4",
			"light_plus": "keyword.operator: #000000",
			"dark_vs": "keyword.operator: #D4D4D4",
			"light_vs": "keyword.operator: #000000",
			"hc_black": "keyword.operator: #D4D4D4"
		}
	}

c: Token content, t: TextMate scope stack, r: Colorizer rules matches.
If there are just changes to the TextMate scope stack but coloring stays the same all is fine.
If there are coloring changes, be alert (I'm happy to help)...

@aeschli aeschli closed this as completed Feb 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

2 participants