Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Tabs vs Spaces in notebooks #205740

Closed
2 tasks done
Yoyokrazy opened this issue Feb 20, 2024 · 2 comments
Closed
2 tasks done

Test: Tabs vs Spaces in notebooks #205740

Yoyokrazy opened this issue Feb 20, 2024 · 2 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Feb 20, 2024

Refs: #108675

Create Issue


Summary:

Notebooks now allow you to choose indentation settings that override the standard editor indentation. These settings will be stored within "notebook.editorOptionsCustomizations"

Steps to Test:

  • Run the command to render whitespace, it will make testing this far easier
  • Open a notebook
  • Check to make sure that the status bar entry in the lower left displays the notebook's indentation
  • Click on the entry and experiment with the various available commands
    • Note: The commands in the convert file lower section of the quickpick are the only ones that will convert the visible indentation within your notebook cells
    • The top three commands in the change view section of the quickpick should all alter the settings within the override listed above, however only will change the visible indentation if you are using tabs and change the display size for example. Compare and contrast to the editor indentation behavior to ensure that there is nothing quirky going on.
    • The bottom two commands in the convert file should convert the indentation within your notebook in EACH cell, not just the current one, as well as changing the setting for insertSpaces from true to false or vice versa

Known Issues:


Thanks so much for testing!

@eleanorjboyd
Copy link
Member

Given known issue I was also running into the problem where this wasn't true "Clicking out of the cell or hitting escape should update the entry as the focus changed. Fix incoming.".

For me instead I have to press escape or click out of the cell somewhere in the notebook, clicking to the terminal did not help.

@eleanorjboyd
Copy link
Member

for the change view section, should I expect updates to my settings? Just a bit confused on when I should see settings.json changes or references to "notebook.editorOptionsCustomizations".

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants