Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot solve merge conflict for cell code with notebook (ipynb) in VSCODE #206279

Closed
HoangMinhPhan opened this issue Feb 26, 2024 · 4 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality merge-conflict Merge conflict decorations and actions notebook
Milestone

Comments

@HoangMinhPhan
Copy link

HoangMinhPhan commented Feb 26, 2024

Type: Bug

I use notebook (ipynb) and keep track of version using git. However, when I want to merge a change in a feature branch to my main branch (the change is done in notebook ipynb). The view of merge conflict is in text editor, not in notebook viewer. It is very difficult to read and solve the merge conflict. Furthermore, I cannot open the merge editor in this case.

VS Code version: Code 1.86.2 (903b1e9, 2024-02-13T19:40:56.878Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-12800H (20 x 2803)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.64GB (17.88GB free)
Process Argv --crash-reporter-id fdbab940-1ecb-4f29-a04b-3a0da7a9618c
Screen Reader no
VM 0%
Extensions (17)
Extension Author (truncated) Version
copilot Git 1.166.0
copilot-chat Git 0.12.2
theme-monokai-pro-vscode mon 1.2.2
black-formatter ms- 2024.0.1
debugpy ms- 2024.0.0
flake8 ms- 2023.10.0
python ms- 2024.0.1
vscode-pylance ms- 2024.2.2
jupyter ms- 2024.1.1
jupyter-keymap ms- 1.1.2
jupyter-renderers ms- 1.0.17
vscode-jupyter-cell-tags ms- 0.1.8
vscode-jupyter-slideshow ms- 0.1.5
material-icon-theme PKi 4.34.0
tabnine-vscode Tab 3.72.0
intellicode-api-usage-examples Vis 0.2.8
vscodeintellicode Vis 1.2.30

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30968133
pythontbext0:30879054
accentitlementst:30887150
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
d34g3935:30971562
edj9j583:30969295

@HoangMinhPhan
Copy link
Author

HoangMinhPhan commented Feb 26, 2024

Below is two pictures for illustration, when I try to open notebook (ipynb) to solve merge between branches.
This picture is a view in a tab of source control
image

This picture is a view in a tab of Explorer
image

@aiday-mar aiday-mar assigned hediet and unassigned aiday-mar Feb 27, 2024
@hediet hediet added feature-request Request for new features or functionality merge-conflict Merge conflict decorations and actions notebook labels Feb 28, 2024
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Feb 28, 2024
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@rebornix rebornix assigned DonJayamanne and unassigned rebornix and hediet Mar 12, 2024
@DonJayamanne DonJayamanne modified the milestones: March 2024, April 2024 Mar 26, 2024
@DonJayamanne DonJayamanne modified the milestones: April 2024, May 2024 Apr 22, 2024
@DonJayamanne
Copy link
Contributor

DonJayamanne commented May 29, 2024

I cannot open the merge editor in this case.

Fixed here #160941

@DonJayamanne DonJayamanne reopened this May 29, 2024
@DonJayamanne DonJayamanne modified the milestones: May 2024, June 2024 May 29, 2024
@DonJayamanne DonJayamanne changed the title Cannot solve merge conflict with notebook (ipynb) in VSCODE Cannot solve merge conflict for cell code with notebook (ipynb) in VSCODE May 29, 2024
@DonJayamanne DonJayamanne modified the milestones: June 2024, Backlog Jun 27, 2024
@DonJayamanne
Copy link
Contributor

Given this issue has only received just 1 upvote since this issue was created and the fact that we now have a way to open the diff editor to resolve merge conflicts, i'm closing this as done.
At the moment, resolving merge conflicts for Notebooks directly in notebook diff editor is not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality merge-conflict Merge conflict decorations and actions notebook
Projects
None yet
Development

No branches or pull requests

6 participants