Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: use createFileSystemWatcher for file events #208872

Closed
8 of 10 tasks
bpasero opened this issue Mar 27, 2024 · 3 comments
Closed
8 of 10 tasks

TypeScript: use createFileSystemWatcher for file events #208872

bpasero opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
file-watcher File watcher on-testplan plan-item VS Code - planned item for upcoming typescript Typescript support issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 27, 2024

Refs: #193848

  • need to check for TS 5.4 at least
  • optimisations
    • pass down need for update/create/delete events all the way down into watcher for correlated requests?
    • deduplicate watchers that correlate to reduce file handles need?
  • is TS deduplicating watch requests on same paths?
  • explore how fs.watch behaves when npm i or git co
  • we should batch events in the extension and only emit in chunks to prevent 1 IPC call per event?
  • enable the setting as experiment, default for insiders but disabled by default (!)
  • see if TypeScript file watcher holds onto folders and causes EPERM TypeScript#54087 is better then
  • explore file access with setting enabled using ProcMon on Windows

cc @sheetalkamat

@bpasero bpasero added typescript Typescript support issues plan-item VS Code - planned item for upcoming labels Mar 27, 2024
@bpasero bpasero added this to the April 2024 milestone Mar 27, 2024
@bpasero bpasero self-assigned this Mar 27, 2024
@bpasero bpasero added the file-watcher File watcher label Mar 27, 2024
@bpasero
Copy link
Member Author

bpasero commented Apr 12, 2024

File Access After:
Image

File Access Before:
Image

@bpasero
Copy link
Member Author

bpasero commented Apr 18, 2024

This is done and behind an experiment that we will enable gradually in stable.

@BurningEnlightenment
Copy link

The current implementation seems to be incompatible with how yarn hooks the SDK to allow access to PnP packages.

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-watcher File watcher on-testplan plan-item VS Code - planned item for upcoming typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants