Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run checks when committing from F1 #20944

Closed
jrieken opened this issue Feb 20, 2017 · 4 comments
Closed

run checks when committing from F1 #20944

jrieken opened this issue Feb 20, 2017 · 4 comments
Assignees
Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@jrieken
Copy link
Member

jrieken commented Feb 20, 2017

  • make changes
  • hit F1 > Git: Commit
  • type a long, long message
  • 🐛 no validation
@joaomoreno joaomoreno added this to the February 2017 milestone Feb 21, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Feb 21, 2017
@joaomoreno
Copy link
Member

Actually I can't do this, otherwise @bpasero prevents the user from submitting that text. I still want him to be able to submit the commit message even if there's a warning/error. Maybe we need more semantics on what can be returned, not just a simple string which means an absolute error.

@bpasero
Copy link
Member

bpasero commented Feb 21, 2017

@joaomoreno @jrieken to clarify we are talking about support to show a warning in the picker widget but still allow to commit it? Sounds like another feature to add to the picker API?

@jrieken
Copy link
Member Author

jrieken commented Feb 21, 2017

Yes, a warning instead of an error as we show it today. The API currently doesn't allow that

@jrieken jrieken added api quick-pick Quick-pick widget issues labels Feb 21, 2017
@bpasero bpasero added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Feb 21, 2017
@bpasero bpasero removed their assignment Mar 8, 2017
@joaomoreno joaomoreno assigned jrieken and unassigned joaomoreno Apr 25, 2017
@jrieken jrieken removed the git GIT issues label Apr 25, 2017
@jrieken jrieken removed this from the Backlog milestone Apr 25, 2017
@jrieken
Copy link
Member Author

jrieken commented Sep 10, 2018

There is now API for this.

@jrieken jrieken closed this as completed Sep 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants