Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are ChatRequestTurn and ChatResponseTurn classes and not interfaces. #213629

Closed
dbaeumer opened this issue May 28, 2024 · 1 comment
Closed

Why are ChatRequestTurn and ChatResponseTurn classes and not interfaces. #213629

dbaeumer opened this issue May 28, 2024 · 1 comment
Assignees
@roblourens

Comments

@dbaeumer
Copy link
Member

dbaeumer commented May 28, 2024 •
edited
Loading

Testing #213514

Their constructor is private so a user can't create any instances anyways.
@benibenj benibenj assigned roblourens and unassigned benibenj May 28, 2024
@roblourens
Copy link
Member

In the API you need to be able to distinguish them, and I think that using instanceof is nicer than differentiating them with a string property or something like that. We also do this kind of thing in other parts of the API.

@microsoft microsoft locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @dbaeumer @benibenj