Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatFollowup is very generic #213631

Closed
dbaeumer opened this issue May 28, 2024 · 5 comments
Closed

ChatFollowup is very generic #213631

dbaeumer opened this issue May 28, 2024 · 5 comments
Assignees
Labels
api chat under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #213514

When reading it the first time in the example I had difficulties binding a meaning to it. The doc comment talks about question. Would it make sense to name it ChatFollowupQuestion of ChatFollowupInput ?

@dbaeumer
Copy link
Member Author

Same for ChatFollowupProvider

@jrieken jrieken added this to the May 2024 milestone May 28, 2024
@jrieken jrieken added api under-discussion Issue is under discussion for relevance, priority, approach chat labels May 29, 2024
@joyceerhl joyceerhl removed their assignment May 29, 2024
@roblourens
Copy link
Member

We could add more detail to the doc comment about how it will be displayed and used, would that help? I wouldn't call it a followup question since it's not necessarily a question. Maybe a ChatFollowupRequest? But I'm not sure the name needs to be changed.

@jrieken
Copy link
Member

jrieken commented May 30, 2024

This is how oxford defines it and I tend to agree that we name is already precise

follow-up | ˈfɒləʊʌp |
noun
a continuation or repetition of something that has already been started or done: [as modifier] : a follow-up study of the > same interviewees after retirement.

Tho, unsure if the correct spelling should be ChatFollowUp?

@dbaeumer
Copy link
Member Author

The thing I had problems with is that you usually follow up on something and it was not clear to me what the follow-up is.

@roblourens roblourens modified the milestones: May 2024, June 2024 May 30, 2024
@jrieken
Copy link
Member

jrieken commented Jun 13, 2024

We kept this as-is. Closing because the API is now finalized

@jrieken jrieken closed this as completed Jun 13, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api chat under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants