Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name LanguageModelChat is confusing for me. #213632

Closed
dbaeumer opened this issue May 28, 2024 · 3 comments
Closed

Name LanguageModelChat is confusing for me. #213632

dbaeumer opened this issue May 28, 2024 · 3 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@dbaeumer
Copy link
Member

Testing #213514

From reading a documentation it is a language model to do chat request. Would it make more sense to name it ChatLanguageModel. The name LanguageModelChat for me point to a chat in a language model.

@jrieken
Copy link
Member

jrieken commented May 28, 2024

I do agree that it needs some "getting used to" the reasoning is to scope the type by names, e.g LanguageModelXYZ because I see a near future in which we also have LanguageModelEmbeddings. This gives type names some namespacing even though it appear the wrong way around

@jrieken jrieken added the under-discussion Issue is under discussion for relevance, priority, approach label May 28, 2024
@jrieken jrieken added this to the May 2024 milestone May 28, 2024
@roblourens
Copy link
Member

I agree that it seems odd at first glance but I think it's fine, and when it sits next to LanguageModelEmbeddings I think it will look better.

@jrieken
Copy link
Member

jrieken commented May 30, 2024

closing this without change

@jrieken jrieken closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@roblourens roblourens removed this from the May 2024 milestone May 30, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants