Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other comments on documentation #213724

Open
eleanorjboyd opened this issue May 28, 2024 · 3 comments
Open

other comments on documentation #213724

eleanorjboyd opened this issue May 28, 2024 · 3 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@eleanorjboyd
Copy link
Member

Testing #213514

if I was beginning this process on my own I think I would have trouble with the const MODEL_SELECTOR: vscode.LanguageModelChatSelector = { vendor: 'copilot', family: 'gpt-3.5-turbo' };. I found in the docs where it describes the only options but this still feel confusing to me bc it took a while to get to this point, it is confusing what type such as "vendor" means and I am unsure how to stay up to date so my chat requests do not get messed up in future releases as more models come out.

when looking through this doc I would love to see something about security. I found the whole page here but it was unclear how these connected and I feel like with this "security first" mindset they talked about a ton at build it might be worth putting something more central about it?

@roblourens
Copy link
Member

I think we can do a better job of explaining the different selector fields, I will propose something.

I am unsure how to stay up to date so my chat requests do not get messed up in future releases as more models come out.

This is no easy answer here- you can write a loose selector that will run your prompts against future models that you haven't tested with, or a more specific selector that will stop working at some point, and then you need to update your extension.

This is sort of mentioned in https://code.visualstudio.com/api/extension-guides/language-model#model-availability, but lmk if you think there's something else we should say.

What aspect of security do you think we should mention? Since the System prompt isn't available to extensions, that is one consideration that extensions don't have to make.

@roblourens roblourens added the under-discussion Issue is under discussion for relevance, priority, approach label May 30, 2024
@AP1400

This comment was marked as spam.

@roblourens
Copy link
Member

Well actually, the LanguageModelChatSelector fields link to the LanguageModelChat fields that have a little more description, and I think that's enough. These fields don't really have a strict definition. But I did add another note on how to use selectChatModels in #213867, hoping it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants