Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsEditorModel leaks text models #21706

Closed
bpasero opened this issue Mar 2, 2017 · 2 comments
Closed

SettingsEditorModel leaks text models #21706

bpasero opened this issue Mar 2, 2017 · 2 comments
Assignees
@sandy081
Labels
debt Code quality issues settings-editor VS Code settings editor issues
Milestone
March 2017

Comments

@bpasero
Copy link
Member

bpasero commented Mar 2, 2017

Looks like the settings editor model creates a reference that it never disposes: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/preferencesService.ts#L225

Refs: #17073

We should fix these right away if possible.
@bpasero bpasero added the debt Code quality issues label Mar 2, 2017
@bpasero bpasero added this to the March 2017 milestone Mar 2, 2017
@sandy081 sandy081 added settings-editor VS Code settings editor issues workbench labels Mar 2, 2017
@sandy081
Copy link
Member

sandy081 commented Mar 2, 2017

This one is back of my mind to clean it up and thanks for reminding it again. Cleaned it up.

@bpasero
Copy link
Member Author

bpasero commented Mar 2, 2017

Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues settings-editor VS Code settings editor issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
2 participants
@bpasero @sandy081