Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deregistering default setting override removes default even if an override is provided by another extension #217188

Closed
benibenj opened this issue Jun 24, 2024 · 0 comments · Fixed by #220108
Closed

Deregistering default setting override removes default even if an override is provided by another extension #217188

benibenj opened this issue Jun 24, 2024 · 0 comments · Fixed by #220108
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
July 2024

Comments

@benibenj
Copy link
Contributor

benibenj commented Jun 24, 2024 •
edited by sandy081
Loading

Testing #217238

Currently when the default overrides from an extension are deregistered, the override value is removed instead of checking if another extension provides a default value for the specific setting.
@benibenj benibenj changed the title Deregistering default setting override removes default even if provided by other extension Deregistering default setting override removes default even if an override is provided by another extension Jun 24, 2024
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues labels Jun 24, 2024
@sandy081 sandy081 modified the milestones: June 2024, July 2024 Jun 24, 2024
sandy081 added a commit that referenced this issue Jul 5, 2024
@sandy081
fix #217188
fd3b419
@sandy081 sandy081 mentioned this issue Jul 5, 2024
Merged
sandy081 added a commit that referenced this issue Jul 7, 2024
@sandy081 @benibenj
fix #217188 (#220108)
c67cd35 
* fix #217188

* fix hover for "set by extension XY"

---------

Co-authored-by: BeniBenj <besimmonds@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 7, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@sandy081 @benibenj @aaronchucarroll
fix microsoft#217188 (microsoft#220108)
cca2b92 
* fix microsoft#217188

* fix hover for "set by extension XY"

---------

Co-authored-by: BeniBenj <besimmonds@microsoft.com>
@sandy081 sandy081 mentioned this issue Jul 22, 2024
Closed
2 tasks
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

fix #217188 microsoft/vscode
3 participants
@sandy081 @benibenj @VSCodeTriageBot