Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useIgnoreFiles structure #223439

Closed
paulacamargo25 opened this issue Jul 24, 2024 · 2 comments
Closed

useIgnoreFiles structure #223439

paulacamargo25 opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@paulacamargo25
Copy link
Contributor

Testing #223154

Overall, i like the design of both APIs. However, the parameter useIgnoreFiles presents a bit of confusion. Given that useIgnoreFiles.local must always be set to true to use the other options, the choice to implement this as a dictionary seems to not have sense. It might be beneficial to reconsider this structure for clarity and ease of use.

@andreamah
Copy link
Contributor

/duplicate #223284

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 24, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants