Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Suggest: Add support for other shells (eg. zsh, bash) #226562

Open
davidthing opened this issue Aug 25, 2024 · 0 comments · Fixed by #233776
Open

Terminal Suggest: Add support for other shells (eg. zsh, bash) #226562

davidthing opened this issue Aug 25, 2024 · 0 comments · Fixed by #233776
Assignees
Labels
api-proposal feature-request Request for new features or functionality terminal-suggest
Milestone

Comments

@davidthing
Copy link

Feature Request

terminal-suggest support for zsh and bash shells, similar to the existing support for Powershell:

image

Ideally, VS Code would pick up the completions that a user already configured for their terminal. As a zsh user (at work) and bash user (at home), I wouldn't mind if enabling this feature required some minimal .zshrc/.bashrc changes (we're used to that kind of thing). It also wouldn't be a deal-breaker if I needed to hit TAB to generate the list of completions, but it'd be nice to have the completions updated after each input change.

Motivation

Terminal completion pop-ups are a feature available in several newer terminals/IDE's like Warp, Fig/AmazonQ, and JetBrains/IntelliJ. I'm quite excited to see that VS Code is adding support for this! However, switching to pwsh isn't in the cards for me. Plus, my teammates all use either zsh or bash, and it's harder for me to sell the idea of using VS Code without this feature.

Beyond the obvious aesthetic improvement, having a pop-up, scrollable list of options can be quite helpful for long lists of completion options, such as git <TAB>:

zsh: do you wish to see all 141 possibilities (141 lines)?

Prior Work

PR #211962 disabled the terminal-suggest feature for all shells except powershell. Therefore it seems not possible to use this feature for any other shells, even with an extension.

@Tyriar Tyriar added the feature-request Request for new features or functionality label Aug 26, 2024
@Tyriar Tyriar changed the title Terminal Suggest: Add support for zsh & bash Terminal Suggest: Add support for other shells (eg. zsh, bash) Aug 26, 2024
@Tyriar Tyriar added this to the Backlog milestone Aug 26, 2024
@Tyriar Tyriar modified the milestones: Backlog, October 2024 Sep 20, 2024
@Tyriar Tyriar removed their assignment Sep 20, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 19, 2024
@meganrogge meganrogge reopened this Dec 10, 2024
@meganrogge meganrogge modified the milestones: November 2024, On Deck Dec 10, 2024
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Dec 10, 2024
@meganrogge meganrogge modified the milestones: On Deck, November 2024 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-proposal feature-request Request for new features or functionality terminal-suggest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants