Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode debug values should take into account source map names #22690

Closed
nojvek opened this issue Mar 15, 2017 · 2 comments
Closed

vscode debug values should take into account source map names #22690

nojvek opened this issue Mar 15, 2017 · 2 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@nojvek
Copy link
Contributor

nojvek commented Mar 15, 2017

The ES5 transpilers such as Typescript and babel translate nested this into _this1, this2 e.t.c

the source map generated by transpiler contains what names should be used as the values but this isn't taken into account via inline values or hover in the editor. To get the actual values, a user has to do guess via console on what the generated property is actually called.

I believe the experience can be improved. Happy to send a PR if you guide me on how to get source map names from the debug adapter.

@roblourens @isidorn

@roblourens
Copy link
Member

We have this issue: #12066 and I think it would be implemented entirely in the debug adapter. A PR would be awesome but I'm not sure exactly what would go into it.

@nojvek
Copy link
Contributor Author

nojvek commented Mar 15, 2017

Okay closing this issue then.

@nojvek nojvek closed this as completed Mar 15, 2017
@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants