Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the GitHub "go to file" fuzzy match algorithm instead of the VS Code Quick Open algorithm #227511

Closed
mrmachine opened this issue Sep 4, 2024 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@mrmachine
Copy link

I always have terrible results with the VS Code Quick Open feature, and excellent results with the GitHub "go to file" feature.

For example, I want to jump to a file djangosite/urls/default.py so I Quick Open and type urldef, but I get this soup in VS Code:

image

In GitHub with "go to file", I get exactly what I want:

image

If I try to separate the two fragments with a space url def (and even try reversing them to def url thinking the first fragment might better match the filename and then be narrowed by path), I get better results, but still the best match is 4th down on the list below what appear to be lower quality matches:

image image

Why does a 3 consecutive character match from the start of the parent directory and covering 75% of the parent directory name (urls) not trump 3x single character matches from anywhere inside separate path fragments? The individually matching characters make up a tiny percentage of the overall length of each fragment, and some are not even matching anywhere near the start of the fragment.

This is my experience often with VS Code where I have to ignore and visually scan past a long list of garbage matches to find the one I actually want. Which is infuriating with the GitHub implementation nails it pretty much every time.

@TylerLeonhardt
Copy link
Member

I think this is in the realm of this issue: #25925
marking as a duplicate.

@TylerLeonhardt TylerLeonhardt added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 3, 2024
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants