Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Keybindings customisations editor #18095 #23287

Closed
3 tasks done
sandy081 opened this issue Mar 27, 2017 · 0 comments
Closed
3 tasks done

Test Keybindings customisations editor #18095 #23287

sandy081 opened this issue Mar 27, 2017 · 0 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Mar 27, 2017

Test for #18095

Complexity : 4

New Keybindings Editor

  • All commands with keybindings are displayed as a flat list sorted by Name of the command
  • All commands without keybindings are listed at the last
  • Keybinding column shows the correct keybinding label in different keyboard layouts
  • Source column shows the source of the keybindings. Either Default / User.
  • When column shows the when context of the keybindings.

Define keybinding

  • Make sure that for all entries either edit or add button is shown on hovering. Edit button is shown for entries with keybindings and add button is shown for those without keybindings.

  • Clicking on this button brings up a widget to provide the keybinding. Test changing keybindings using this widget. Try various key combinations.

  • Make sure the keybinding association works.

  • Make sure the keyboard shortcut works to define keybinding

Remove keybinding

  • Right click on an entry with keybinding and click remove keybinding action in the context menu
  • Make sure that keybinding is removed.
  • This action is available only for commands with keybindings.
  • Make sure the keyboard shortcut works to remove keybinding

Reset keybinding

  • Right click on an entry with Source is User and click reset keybinding action in the context menu
  • Make sure that the default keybindings is assigned back.
  • This actions in available only for commands with source is User.

Copy action

  • Right click on any entry and click copy action in the context menu
  • Test it copies the json keybinding object. When key is omitted if there is no when context.
  • Make sure the keyboard shortcut works to copy

Open keybindings.json

  • On the top of the list, there is a link to open keybindings.json file. Make sure it opens keybindings editor as before (Defaults and Editable files).

  • Do changes in keybindings.json and make sure that these changes are reflected in the new editor.

Search

Supports searching in following

  • cmd/ctrl + f focuses Search input box

  • Command id / Command label / Command default label (when local is not english). Highlights are shown if one of these labels matches with search criteria

  • Matches keybinding labels. Labels are shown as they are in some platforms. In other platforms like Mac, labels are shown on hovering on the keybinding symbols. Currently, label match highlights are shown explicitly when matched. In some platforms this could be duplicate but there is plan to improve the highlight the symbols.

  • Search is also supported in Source and When columns.

  • Each row is filtered only if all search words are matched in at least one of the above.

Accessibility

  • Make sure that this editor has accessibility features
@sandy081 sandy081 added this to the March 2017 milestone Mar 27, 2017
@alexdima alexdima removed their assignment Mar 28, 2017
@weinand weinand removed their assignment Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants