Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The focused element should always be visible #2336

Closed
alexdima opened this issue Jan 26, 2016 · 4 comments
Closed

The focused element should always be visible #2336

alexdima opened this issue Jan 26, 2016 · 4 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues ux User experience issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

Testing #2145

In this case, I have resized the viewlet area in such a way that the Start (F5) button is pushed out of the viewport. The button should not be focusable if it is not visible, alternatively the viewlet area should have a different min-width when the debug viewlet is open or the debug viewlet should get a horiz. scrollbar.

Steps: Shift-tab a lot => you will no longer see the active element once you reach the Start (F5) button.

image

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 26, 2016
@bpasero bpasero modified the milestones: Jan 2016, Feb 2016 Jan 26, 2016
@bpasero bpasero added ux User experience issues and removed bug Issue identified by VS Code Team member as probable bug labels Feb 1, 2016
@bpasero
Copy link
Member

bpasero commented Feb 1, 2016

I wonder if this is a requirement. For example I have tested on Windows, tabbing into a tree where the focused element is not visible and I do not see the element scroll into view. @stevencl maybe you know the answer here.

@bpasero bpasero assigned stevencl and unassigned bpasero Feb 1, 2016
@alexdima
Copy link
Member Author

alexdima commented Feb 2, 2016

Yeah, it would also be pretty hard to implement this given we support zoom in like this:

image

So it's ok with me to close :)

@bpasero
Copy link
Member

bpasero commented Feb 2, 2016

👍

@bpasero bpasero closed this as completed Feb 2, 2016
@stevencl
Copy link
Member

stevencl commented Feb 2, 2016

I don't know the answer in terms of accessibility. It does feel odd that a button can be focusable if it is not visible.

For the specific scenario listed above I think we should consider other ways to deal with command placement when resizing the viewlet. But that is for another bug.

@stevencl stevencl added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants