Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad NLS concatenation #234328

Closed
bpasero opened this issue Nov 21, 2024 · 0 comments · Fixed by #234457
Closed

Bad NLS concatenation #234328

bpasero opened this issue Nov 21, 2024 · 0 comments · Fixed by #234457
Assignees
@bhavyaus
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Milestone
November 2024

Comments

@bpasero
Copy link
Member

bpasero commented Nov 21, 2024

vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedInput.ts

Line 78 in 969b571

return this.walkthroughPageTitle ? localize('walkthroughPageTitle', 'Walkthrough: ') + this.walkthroughPageTitle : localize('getStarted', "Welcome");

This should be:

localize('walkthroughPageTitle', 'Walkthrough: {0}', this.walkthroughPageTitle)
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 21, 2024
@bhavyaus bhavyaus mentioned this issue Nov 22, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 22, 2024
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 22, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavyaus bhavyaus

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

fix: update localization for walkthrough page title in GettingStartedInput microsoft/vscode
2 participants
@bpasero @bhavyaus