Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more detailed ligature types in terminal #235316

Closed
Tyriar opened this issue Dec 4, 2024 · 5 comments · Fixed by #237503
Closed

Support more detailed ligature types in terminal #235316

Tyriar opened this issue Dec 4, 2024 · 5 comments · Fixed by #237503
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-ligatures upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2024

From @joshlawton in #34103 (comment)

Just to confirm, this setting only accepts a boolean value and does not enable explicit font-feature-settings like ss01 or cv69? That is, even if terminal.integrated.fontLigatures is true, the font may not necessarily match the style sets and character variants enabled in the editor?

// settings.json

// Works
"terminal.integrated.fontLigatures": true

// Won't work as expected at this time?
"terminal.integrated.fontLigatures": "'calt', 'liga', 'ss19', 'cv69'"

Compare editorOptions.ts to terminalConfiguration.ts.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-rendering labels Dec 4, 2024
@Tyriar Tyriar added this to the Backlog milestone Dec 4, 2024
@Tyriar Tyriar self-assigned this Dec 4, 2024
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Dec 4, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Dec 4, 2024

Cross posting from #34103 (comment)

If someone can figure out how to pass that information on to an OffscreenCanvas it should be trivial to add the support: https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvasRenderingContext2D#text_styles

@Tyriar
Copy link
Member Author

Tyriar commented Dec 4, 2024

I think we can support it if it weren't an OffscreenCanvas by setting the CSS. Which is a shame if that's the only way as we'd need to swap the canvas type depending on ligature config.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 6, 2025

@Tyriar
Copy link
Member Author

Tyriar commented Jan 8, 2025

Upstream: xtermjs/xterm.js#5284

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Jan 8, 2025
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-ligatures upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant