Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut key combination with shift+option key is not working. #23790

Closed
shekhardtu opened this issue Apr 1, 2017 · 6 comments
Closed

Shortcut key combination with shift+option key is not working. #23790

shekhardtu opened this issue Apr 1, 2017 · 6 comments
Assignees
Labels
*as-designed Described behavior is as designed keybindings VS Code keybinding issues macos Issues with VS Code on MAC/OS X
Milestone

Comments

@shekhardtu
Copy link

shekhardtu commented Apr 1, 2017

Hi,
I am using VS code Version 1.10.2 (1.10.2). Whenever I am trying to use shortcut key in combination with shift+option+F key that's not working instead leaving a special character " ̰ " on screen.

  • VSCode Version: 1.10.2 (1.10.2)
  • OS Version: macOS Sierra v10.12.4 (16E195)

Steps to Reproduce:

  1. Open any JS file.
  2. Try to format is using "option+shift+F"
@alexdima alexdima added the macos Issues with VS Code on MAC/OS X label Apr 3, 2017
@alexdima alexdima self-assigned this Apr 3, 2017
@alexdima alexdima added the keybindings VS Code keybinding issues label Apr 3, 2017
@alexdima
Copy link
Member

alexdima commented Apr 3, 2017

@harishekhar This milestone we have changed how keybinding dispatching works on OSX to use e.code (See #17521).

Can you please try in the Insiders Build that contains all these changes?

@alexdima alexdima added the info-needed Issue requires more information from poster label Apr 3, 2017
@alexdima alexdima added this to the Backlog milestone Apr 3, 2017
@alexdima
Copy link
Member

alexdima commented May 5, 2017

Closing after a number of days without a response.

@alexdima alexdima closed this as completed May 5, 2017
@santekotturi
Copy link

Tried the Insiders build today. I'm still seeing this issue.
code format not working demo

macOS 10.12.4

@alexdima
Copy link
Member

alexdima commented May 8, 2017

@skotturi What keyboard layout do you use? What type of physical keyboard do you use: ANSI, ISO or JIS?

@alexdima alexdima reopened this May 8, 2017
@santekotturi
Copy link

@alexandrudima I wasn't sure so I went into Sys Pref > Keyboard > Input Sources. My keyboard was set to "ABC Extended". I changed this to "ABC" and the issue is gone. No idea how that changed, vscode seemed to be the only place where the keybinding difference showed up.

image

@alexdima alexdima modified the milestones: On Deck, Backlog May 8, 2017
@alexdima
Copy link
Member

I have just investigated this issue using the ABC - Extended keyboard layout.

When pressing shift+option+F , we receive a compositionstart event and enter composition mode. This is similar e.g. to how composition acts when inputting CJK languages. Our handling of this case is IMHO correct.

@alexdima alexdima added *as-designed Described behavior is as designed and removed info-needed Issue requires more information from poster labels May 19, 2017
@alexdima alexdima modified the milestones: Backlog, On Deck May 19, 2017
@alexdima alexdima modified the milestones: Backlog, May 2017 May 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed keybindings VS Code keybinding issues macos Issues with VS Code on MAC/OS X
Projects
None yet
Development

No branches or pull requests

3 participants